Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard coding of ID column #9

Open
SteveBronder opened this issue Nov 16, 2019 · 2 comments
Open

Remove hard coding of ID column #9

SteveBronder opened this issue Nov 16, 2019 · 2 comments

Comments

@SteveBronder
Copy link

In cFit it looks like you are hardcoding

    idcol='id'
    obsTpoints=max(unlist(lapply(unique(dat[,idcol]),function(x) 
      length(dat[dat[,idcol]==x, idcol]) )))

But the user specifies that in the model function so I think you can just make it

 idcol <- ctmodelobj$id
@cdriveraus
Copy link
Owner

Thanks, this was changed for the benefit of the newer estimation approach using ctStanFit instead of ctFit, which treats id more decently. I'm not devoting much maintenenance energy to the older openmx based approach and am worried that the test coverage to pick up a problem here may not be adequate, so I'm not resolving yet, but, noted, and I will try address it at some point! :)

@SteveBronder
Copy link
Author

lol oh whoops! It may be good to just throw a @deprecated tag on that func then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants