Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Update Fork #1
What type of PR is this? (check all applicable)
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?
… [deploy] * Consolidate `.decorate` calls * Move Activerecord finders out of main stories feed partial * Add back in decorates to sticky_articles partial * Combine top and new articles returned from StoriesController * Extract feed construction logic to a service * Some PR tweaks (naming) * Quick test fix
* TagsController inherits from ApiController * Let ApiController inherit from ActionController::Base to have its own lifecycle * Remove unused method * Use only one respond_to :json for the entire API * ApiController inherits from ActionController::Base * Use Pundit only where needed
… [deploy] * Add "Welcome" type to Broadcasts, allow dynamic "authoring" of Broadcasts This adds a new `type_of` to the Broadcast model: "Welcome". As we begin to create a new "welcome notification" workflow, we'll categorize them by making them all of the same type. This also adds a concept of a "welcoming user", which can be set via an ENV var. The WELCOMING_USER_ID will allow us to explicitly set (and change) which user in the database is the one that "sends" welcoming notification. In production, we plan for this to be dev.to/sloan. * Allow WelcomeNotificationWorker to accept + send any kind of broadcast This abstracts out the logic of deciding which broadcast to send from the woker into the calling method. This will help us send many different kinds of welcome notifications using one, resuable worker class. * Raise if a Notification can't be created * Add STAFF_USER_ID as an ENV var This is in preparation for moving away from SiteConfig.staff_user_id, and replacing it with an ENV var. We will need to set this in production first, and then make a separate PR to replace all instances of staff_user_id with the newly-set ENV var.
…) [deploy] * Add additional safeguards for config write access * Change spec name and confirmation step
* Started moving sponsorships to /internal * Moving sponsorships to /internal * Improved /internal/sponsorships * Added destroying sponsorships to /internal * Rename sponsorships creator in internal
…acticaldev#6387) * Add documentation for how to install ES from brew * A bit clearer * Update docs/installation/mac.md Co-Authored-By: Ridhwana <Ridhwana.Khan16@gmail.com> * Update docs/installation/mac.md Co-Authored-By: Ridhwana <Ridhwana.Khan16@gmail.com> * Move testing section after installation * Update docs/installation/mac.md Co-Authored-By: Vaidehi Joshi <firstname.lastname@example.org> * Update docs/installation/mac.md Co-Authored-By: Vaidehi Joshi <email@example.com> Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com> Co-authored-by: Vaidehi Joshi <firstname.lastname@example.org>
) [deploy] When an article is updated the associated collection is touched along with all its articles. This creates a deadlock where two transaction(nested) lock the article that was updated. With this commit the collection wll be touched after the article updates transaction has been commited. Doing so we have two sequential transactions.
Bumps [stripe](https://github.com/stripe/stripe-ruby) from 5.15.0 to 5.17.0. - [Release notes](https://github.com/stripe/stripe-ruby/releases) - [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md) - [Commits](email@example.com...v5.17.0) Signed-off-by: dependabot-preview[bot] <firstname.lastname@example.org>
Bumps [elasticsearch](https://github.com/elasticsearch/elasticsearch-ruby) from 7.4.0 to 7.5.0. - [Release notes](https://github.com/elasticsearch/elasticsearch-ruby/releases) - [Changelog](https://github.com/elastic/elasticsearch-ruby/blob/v7.5.0/CHANGELOG.md) - [Commits](email@example.com...v7.5.0) Signed-off-by: dependabot-preview[bot] <firstname.lastname@example.org>
Bumps [better_errors](https://github.com/BetterErrors/better_errors) from 2.5.1 to 2.6.0. - [Release notes](https://github.com/BetterErrors/better_errors/releases) - [Commits](BetterErrorsemail@example.com...v2.6.0) Signed-off-by: dependabot-preview[bot] <firstname.lastname@example.org>
Bumps [bootsnap](https://github.com/Shopify/bootsnap) from 1.4.5 to 1.4.6. - [Release notes](https://github.com/Shopify/bootsnap/releases) - [Changelog](https://github.com/Shopify/bootsnap/blob/master/CHANGELOG.md) - [Commits](Shopifyemail@example.com...v1.4.6) Signed-off-by: dependabot-preview[bot] <firstname.lastname@example.org>
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.10.8 to 1.10.9. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/v1.10.9/CHANGELOG.md) - [Commits](email@example.com...v1.10.9) Signed-off-by: dependabot-preview[bot] <firstname.lastname@example.org>
* Add EmailAuthorization model * Add model file oops * Add comment for uuid type Co-authored-by: Ben Halpern <email@example.com>
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.