Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

May 2018 Ballot Comment 14 #220

Closed
cds-hooks-bot opened this issue May 16, 2018 · 2 comments · Fixed by #421
Closed

May 2018 Ballot Comment 14 #220

cds-hooks-bot opened this issue May 16, 2018 · 2 comments · Fixed by #421
Assignees
@kpshek
Labels
ballot/block 1 ballot HL7 ballot comment
Milestone
1.0

Comments

@cds-hooks-bot
Copy link
Collaborator

May 2018 Ballot Comment 14

Submitted by @bvdh from Philips Healthcare

Chapter: CDS Services
Section: Calling a CDS Service - http request
Type: A-Q ❓
In Person Requested? Yes 👤

Existing Wording:

The FHIR resource type + id representing the current user.
The type is one of: Practitioner, Patient, or RelatedPerson.
For example, Practitioner/123

Comment:
What will this field mean if no FHIR server is provided? Wouldn't a full URL be better?

Triage Information

Triage Notes:
Reviewed with Bas

Proposed Disposition: Persuasive
Proposed Disposition Comment:
Change the user field documentation to state:

The id of the user. For example, if the user represents a FHIR resource on the given FHIR server...(existing documentation we have today).

This issue was imported by @cds-hooks-bot from the consolidated CDS Hooks May 2018 ballot spreadsheet.
@cds-hooks-bot cds-hooks-bot added this to the 1.0 milestone May 16, 2018
@cds-hooks-bot cds-hooks-bot added the ballot HL7 ballot comment label May 16, 2018
@cds-hooks-bot
Copy link
Collaborator Author

Proposed Disposition: Persuasive
Proposed Disposition Comment:
Change the user field documentation to state:

The id of the user. For example, if the user represents a FHIR resource on the given FHIR server...(existing documentation we have today).

@cds-hooks-bot
Copy link
Collaborator Author

📞 CDS Working Group Block Vote (5-30-2018)

Meeting notes: http://wiki.hl7.org/index.php?title=File:2018-05-30_CDS_WG_Call_Minutes.docx

Julia Skapik moved the following disposition, seconded by @brynrhodes.

Disposition: Persuasive
Disposition Comment:
Change the user field documentation to state:

The id of the user. For example, if the user represents a FHIR resource on the given FHIR server...(existing documentation we have today).

👍 For: 12
😑 Abstain: 0
👎 Against: 0

🎉 The motion passed! 🎉

kpshek added a commit that referenced this issue Nov 2, 2018
@kpshek
Clarify user documentation (fixes #220)
d89bc6d
@kpshek kpshek mentioned this issue Nov 2, 2018
Merged
kpshek added a commit that referenced this issue Nov 13, 2018
@kpshek
Clarify user documentation (fixes #220) (#421)
5f69991
brynrhodes added a commit that referenced this issue Nov 13, 2018
@brynrhodes
Incorporated changes from #220
8689415
kpshek pushed a commit that referenced this issue Nov 13, 2018
@brynrhodes @kpshek
#232: Move "user" from the request to each individual hook (#425)
b437b01 
* #232: Removed "user" from the request and added it to each of the defined hooks as "userId". Updated relevant examples, yaml, and removed the "user" prefetch token defined by the spec.

* Incorporated changes from #220 

Fixes #232
Fixes #307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kpshek kpshek

Labels
ballot/block 1 ballot HL7 ballot comment
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Clarify user documentation (fixes #220) cds-hooks/docs
2 participants
@kpshek @cds-hooks-bot