Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

May 2018 Ballot Comment 26 #232

Closed
cds-hooks-bot opened this issue May 16, 2018 · 0 comments

Comments

@cds-hooks-bot
Copy link
Collaborator

commented May 16, 2018

May 2018 Ballot Comment 26

Submitted by @bvdh from Philips Healthcare

Chapter: CDS Services
Section: Prefetch template
Type: A-Q
In Person Requested? Yes 👤

Existing Wording:

}}, MUST be named based upon the field they correspond to,

Comment:
Why do we need to enforce this as a mandatory requirement. Is it a requirement at all?

🇩🇪 Köln May 2018 Working Group Vote

@jmandel moved the following disposition, seconded by @brynrhodes.

Disposition: Persuasive with Mod
Disposition Comment:
Move the CDS Service request "user" field to the hook context and document that each hook author shall include the "user" context field if it is appropriate for their hook. We acknowledge this breaking change but feel now is the time to do this. In doing this, we will address the ballot comment (by clarifying that prefetch templates relate to context parameters) and possibly allow for non-user initiated CDS Hooks calls.

👍 For: 24
😑 Abstain: 0
👎 Against: 0

🎉 The motion passed! 🎉


This issue was imported by @cds-hooks-bot from the consolidated CDS Hooks May 2018 ballot spreadsheet.

@cds-hooks-bot cds-hooks-bot added this to the 1.0 milestone May 16, 2018

@isaacvetter isaacvetter added the prefetch label Jun 6, 2018

@kpshek kpshek added the substantive label Aug 2, 2018

brynrhodes added a commit that referenced this issue Nov 7, 2018

#232: Removed "user" from the request and added it to each of the def…
…ined hooks as "userId". Updated relevant examples, yaml, and removed the "user" prefetch token defined by the spec.

@kpshek kpshek closed this in #425 Nov 13, 2018

kpshek added a commit that referenced this issue Nov 13, 2018

#232: Move "user" from the request to each individual hook (#425)
* #232: Removed "user" from the request and added it to each of the defined hooks as "userId". Updated relevant examples, yaml, and removed the "user" prefetch token defined by the spec.

* Incorporated changes from #220 

Fixes #232
Fixes #307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.