Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

May 2018 Ballot Comment 143 #349

Closed
cds-hooks-bot opened this issue May 16, 2018 · 2 comments
Closed

May 2018 Ballot Comment 143 #349

cds-hooks-bot opened this issue May 16, 2018 · 2 comments
Assignees
@brynrhodes
Labels
ballot/block 1 ballot HL7 ballot comment grammar prefetch Issue is related to the prefetch functionality of the specification
Milestone
1.0

Comments

@cds-hooks-bot
Copy link
Collaborator

May 2018 Ballot Comment 143

Submitted by Walter Suarez from Kaiser Permanente

Chapter:
Section: Prefetch Query - Prefetch Query Restrictions
Type: A-S 💡
In Person Requested? No

Comment:
"Valid pefetch URLs should only contain:…" should it not be "Valid prefetch URLs MUST only contain:"?

This issue was imported by @cds-hooks-bot from the consolidated CDS Hooks May 2018 ballot spreadsheet.
@cds-hooks-bot cds-hooks-bot added this to the 1.0 milestone May 16, 2018
@cds-hooks-bot cds-hooks-bot added the ballot HL7 ballot comment label May 16, 2018
@cds-hooks-bot
Copy link
Collaborator Author

Proposed Disposition: Not Persuasive with Mod
Proposed Disposition Comment:
We did indeed intend for this to be SHOULD (we will ensure the conformance language is correctly capitalized)

@cds-hooks-bot
Copy link
Collaborator Author

📞 CDS Working Group Block Vote (5-30-2018)

Meeting notes: http://wiki.hl7.org/index.php?title=File:2018-05-30_CDS_WG_Call_Minutes.docx

Julia Skapik moved the following disposition, seconded by @brynrhodes.

Disposition: Not Persuasive with Mod
Disposition Comment:
We did indeed intend for this to be SHOULD (we will ensure the conformance language is correctly capitalized)

👍 For: 12
😑 Abstain: 0
👎 Against: 0

🎉 The motion passed! 🎉

@isaacvetter isaacvetter added the prefetch Issue is related to the prefetch functionality of the specification label Jun 6, 2018
brynrhodes added a commit that referenced this issue Nov 24, 2018
@brynrhodes
#349: Corrected capitalization of conformance language in prefetch de…
fec095d 
…scription
@brynrhodes brynrhodes mentioned this issue Nov 24, 2018
Merged
brynrhodes added a commit that referenced this issue Dec 5, 2018
@brynrhodes
Fixes #238: Clarified how prefetch templates are processed
cad7f75 
Fixes #239: Clarified prefetch data conformance language
Fixes #242: Added definition for prefetch key
Fixes #244: Updated conformance language usage in prefetch restrictions
Fixes #246: Clarified prefetch limitations are on prefetch templates
Fixes #257: Added clarification on responses and notes about multiple services from the same hook
Fixes #262: Added examples for each action type
Fixes #264: Clarified documentation for actions
Fixes #274: Clarified hook context table is an example
Fixes #281: Clarified prefetch response resources may be a searchset bundle
Fixes #282: Provided rationale for the use of null in the prefetch response
Fixes #287: Clarified allowable data types for context fields
Fixes #289: Changed prefetch token status change to Major
Fixes #298: Added examples to hook/prefetch discussion
Fixes #300: Added an overview section discussing CDS Hooks components
Fixes #313: Clarified definitions of prefetch template, prefetch token, and prefetch key
Fixes #314: Clarified prefetch behavior for multiple services attached to the same hook
Fixes #316: Added rationale for not allowing next page links in prefetch data
Fixes #344: Clarified distinction between context and prefetch
Fixes #343: Updated prefetch example to use full key names
Fixes #349: Corrected capitalization of conformance language in prefetch description
kpshek added a commit that referenced this issue Dec 5, 2018
@kpshek
Merge pull request #435 from cds-hooks/non-substantive-ballot-changes
a66da93 
Non substantive ballot changes.

Fixes #238: Clarified how prefetch templates are processed
Fixes #239: Clarified prefetch data conformance language
Fixes #242: Added definition for prefetch key
Fixes #244: Updated conformance language usage in prefetch restrictions
Fixes #246: Clarified prefetch limitations are on prefetch templates
Fixes #257: Added clarification on responses and notes about multiple services from the same hook
Fixes #262: Added examples for each action type
Fixes #264: Clarified documentation for actions
Fixes #274: Clarified hook context table is an example
Fixes #281: Clarified prefetch response resources may be a searchset bundle
Fixes #282: Provided rationale for the use of null in the prefetch response
Fixes #287: Clarified allowable data types for context fields
Fixes #289: Changed prefetch token status change to Major
Fixes #298: Added examples to hook/prefetch discussion
Fixes #300: Added an overview section discussing CDS Hooks components
Fixes #313: Clarified definitions of prefetch template, prefetch token, and prefetch key
Fixes #314: Clarified prefetch behavior for multiple services attached to the same hook
Fixes #316: Added rationale for not allowing next page links in prefetch data
Fixes #344: Clarified distinction between context and prefetch
Fixes #343: Updated prefetch example to use full key names
Fixes #349: Corrected capitalization of conformance language in prefetch description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brynrhodes brynrhodes

Labels
ballot/block 1 ballot HL7 ballot comment grammar prefetch Issue is related to the prefetch functionality of the specification
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
4 participants
@isaacvetter @brettmarquard @brynrhodes @cds-hooks-bot