Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ircc form #81

Merged
merged 2 commits into from Feb 25, 2021
Merged

Ircc form #81

merged 2 commits into from Feb 25, 2021

Conversation

nmakuch
Copy link
Contributor

@nmakuch nmakuch commented Feb 24, 2021

No description provided.

@bryan-robitaille bryan-robitaille temporarily deployed to platform-for-ircc-form-y1f1wps February 24, 2021 23:06 Inactive
@github-actions
Copy link
Contributor

Code coverage

Filename Statements Branches Functions Lines
lib/logger.tsx 60% 62.5% 75% 57.14%
components/forms/Alert/Alert.tsx 100% 75% 100% 100%
components/forms/ErrorMessage/ErrorMessage.tsx 100% 100% 100% 100%
components/forms/Button/Button.tsx 100% 100% 100% 100%
components/forms/Checkbox/Checkbox.tsx 100% 50% 100% 100%
components/forms/Dropdown/Dropdown.tsx 100% 60% 100% 100%
components/forms/Fieldset/Fieldset.tsx 100% 50% 100% 100%
components/forms/FormGroup/FormGroup.tsx 100% 100% 100% 100%
components/forms/Label/Label.tsx 100% 50% 100% 100%
components/forms/Radio/Radio.tsx 100% 50% 100% 100%
components/forms/TextArea/TextArea.tsx 100% 50% 100% 100%
components/forms/TextInput/TextInput.tsx 100% 50% 100% 100%
components/forms/FileInput/FileInput.tsx 50% 33.33% 33.33% 50%
components/forms/Description/Description.tsx 100% 100% 100% 100%
components/forms/DynamicRow/DynamicRow.tsx 10% 0% 0% 10%
components/forms/Heading/Heading.tsx 100% 100% 100% 100%
components/forms/Form/Form.tsx 31.25% 0% 28.57% 31.25%
components/forms/index.ts 100% 100% 100% 100%
lib/formBuilder.tsx 43.06% 30.51% 46.67% 43.06%

Copy link
Contributor

@fitore-cds fitore-cds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mcman12
Copy link
Contributor

mcman12 commented Feb 25, 2021

@nmakuch paragraph should not be in H2, should probably use "plaintext" components. tx

@nmakuch
Copy link
Contributor Author

nmakuch commented Feb 25, 2021

chatted with Mario a bit on slack but I'm going to merge this in. The form itself is awkward (I converted as is with little design intervention) and has ridiculously long labels (sometimes 2 paragraphs :s). I think a better solution to this would be a content design review as the labels for the questions themselves should probably be reworked.

@nmakuch nmakuch merged commit f4f561f into main Feb 25, 2021
@brdunfield brdunfield deleted the ircc-form branch June 2, 2021 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants