Commits on Sep 24, 2023

1. CLI: fix line buffering with Python 3 (cea-hpc#528) …

   When the code was ported to Python 3, we switched to sys.stdout.buffer
   and sys.stderr.buffer that use BufferedWriter (bytes) for printing
   outputs. However, this method doesn't work great for line buffering,
   which is used a lot by clush and clubak.
   
   Switch back to sys.stdout and sys.stderr, as TextIOWrapper objects,
   which take strings and benefit from automatic line buffering.
   If stdout (or stderr) is not a tty, we reconfigure it (only once) to
   force line buffering. Indeed, clush and clubak might be piped to other
   tools (like pv) that expects each line to be flushed.
   
   Key aspects of this patch:
   
   - write() to stdout/stderr now takes a string and the Display class is
   in charge of performing the needed bytes-to-string decoding
   
   - any non-printable character will be decoded to U+FFFD thanks to
   errors='replace'; U+FFFD is the official REPLACEMENT CHARACTER (this
   is now tested in CLIDisplayTest.py)
   
   - when the Display object is initialized, we make sure stdout/stderr
   are configured with line buffering enabled
   
   - the print methods from Display like print_line(), print_line_error()
   and _print_content() still take bytes as argument. Buffers are still
   mainly handled as bytes internally (by MsgTreeElem)
   
   - most CLI tests remain unchanged for now: they capture the output (now
   as string) and compare against expected bytes, but proper encoding is
   done by TLib in CLI_main(). In the future, we could convert all tests
   from using bytes to string to make it easier.
   
   Fixes cea-hpc#528.

   

   thiell committed Sep 24, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 3d4b312
   • Browse repository at this point

   Copy the full SHA

   3d4b312 View commit details

   Browse the repository at this point in the history