Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed table rendering for lines begining with | for GFM #151

Closed
wants to merge 7 commits into from
Closed

Fixed table rendering for lines begining with | for GFM #151

wants to merge 7 commits into from

Conversation

marekdedic
Copy link
Contributor

Altered table rendering so that it is more in line with what Github does.

The problem was (for example) in tables such as:

**Délka**|**Věk**|**Zač.**| |**Pokr.**| |**Vysp.**| |**Rychlost km/h**
:-----:|:-----:|:-----:|:-----:|:-----:|:-----:|:-----:|:-----:|:-----:
| | |*km*|*kg*|*km*|*kg*|*km*|*kg*| 
*1 den*|4 - 6|6|-|-|-|-|-|do 2
 |6 - 7|7|-|8|-|9|-|2,5
 |7 - 9|8|2|10|2|12|2|3
 |9 - 11|10|4|12|5|14|6|3
 |11 - 13|12|6|15|7|18|6|3,5
 |13 - 15|15|7,5|18|9|21|10,5|4
 |15 - 18|20|9,5|25|12|30|14,5|4,5
*2 dny*|10 - 11|15|4|20|5|24|6|3
 |11 - 13|20|6|25|7|30|8|3,5
 |13 - 15|25|7,5|30|9|35|10,5|4
 |15 - 18|36|9,5|45|12|54|14,5|4,5
*3 dny*|12 - 13|28|6|35|7|42|8|3,5
 |13 - 15|33|7,5|40|9|47|10,5|4
 |15 - 18|48|9,5|60|12|72|14,5| 
Délka Věk Zač. Pokr. Vysp. Rychlost km/h
km kg km kg km kg
1 den 4 - 6 6 - - - - - do 2
6 - 7 7 - 8 - 9 - 2,5
7 - 9 8 2 10 2 12 2 3
9 - 11 10 4 12 5 14 6 3
11 - 13 12 6 15 7 18 6 3,5
13 - 15 15 7,5 18 9 21 10,5 4
15 - 18 20 9,5 25 12 30 14,5 4,5
2 dny 10 - 11 15 4 20 5 24 6 3
11 - 13 20 6 25 7 30 8 3,5
13 - 15 25 7,5 30 9 35 10,5 4
15 - 18 36 9,5 45 12 54 14,5 4,5
3 dny 12 - 13 28 6 35 7 42 8 3,5
13 - 15 33 7,5 40 9 47 10,5 4
15 - 18 48 9,5 60 12 72 14,5

@marekdedic marekdedic changed the title Tables Fixed table rendering for lines begining with | for GFM Mar 12, 2018
@cebe cebe modified the milestones: 1.2, 1.1.3 Mar 13, 2018
@cebe cebe self-assigned this Mar 13, 2018
@cebe cebe closed this in b6a3375 Mar 13, 2018
@cebe
Copy link
Owner

cebe commented Mar 13, 2018

Merged, thank you!

@marekdedic
Copy link
Contributor Author

May I ask why you have commited the code instead of merging the PR? Not that I mind in any way, just curious...

@marekdedic marekdedic deleted the tables branch March 14, 2018 10:03
@cebe
Copy link
Owner

cebe commented Mar 14, 2018

I check out the branch, tested the code, and rebased on master. Just another workflow and creates a cleaner git history than with merge commits, e.g. avoids to have things like this in the history c64396a. You are still the author of the commit, reflected in https://github.com/cebe/markdown/graphs/contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants