Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default button styling #6

Closed
OfficerHalf opened this issue Nov 2, 2021 · 3 comments
Closed

Default button styling #6

OfficerHalf opened this issue Nov 2, 2021 · 3 comments

Comments

@OfficerHalf
Copy link

@OfficerHalf OfficerHalf commented Nov 2, 2021

Looks like buttons without some sort of class applied aren't getting completely styled, and are still getting background-color: var(--interactive-normal), which I don't think your theme has replaced, so the button just looks really out of place:

image

This isn't a big deal; as far as I know buttons are only used in the main app inside modals, and those are styled. But plugins are wily and add them other places.

@ceciliamay
Copy link
Owner

@ceciliamay ceciliamay commented Nov 6, 2021

I'd love for you to use the cute buttons I made though 😭

That specific "Manage" button (and other CTA buttons) is supposed to look like this:
image

But general buttons in Dark Mode are supposed to look like this:
image

I feel that something else is overriding the style. Can I get a list of all the plugins you're using? I want to replicate the issue on my end and see if I can get it fixed 😄

@OfficerHalf
Copy link
Author

@OfficerHalf OfficerHalf commented Nov 6, 2021

Yeah, sorry that screenshot was a poor example. That was me playing in the devtools attempting to figure out why the buttons in my Trello plugin didn't look right. Here it is from the plugin:

image

My plugin doesn't add any styles to the button it just plops it there with no class as a <button type="button"></button>

@ceciliamay
Copy link
Owner

@ceciliamay ceciliamay commented Nov 7, 2021

This has been fixed in Release v.0.1.1! 🎉 Thank you so much for letting me know of this issue! Cute buttons FTW!! 😆

@ceciliamay ceciliamay closed this Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants