Merged
Conversation
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
adpaco-aws
reviewed
Dec 6, 2024
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
john-h-kastner-aws
approved these changes
Dec 6, 2024
adpaco-aws
approved these changes
Dec 6, 2024
benelser
pushed a commit
to benelser/cedar
that referenced
this pull request
Jan 16, 2026
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
New builtin
.isEmpty()method, which works on Sets. Implemented similarly to.contains()which works on Sets. This is our first builtin method that takes 0 arguments other than its receiver (although we have extension methods that take 0 arguments other than their receiver).This PR contains the changes necessary in this repo (unless I've missed something); we'll also need changes in DRT, the Lean model, and the public docs.
Issue #, if available
Fixes #1356
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy(e.g., addition of a new API).I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):cedar-spec, and how you have tested that your updates are correct.)I confirm that
docs.cedarpolicy.com(choose one, and delete the other options):cedar-docs. PRs should be targeted at astaging-X.Ybranch, notmain.)