Unescape visible code tags in release-actions component #197
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The combination of the tagged template literal, and
sprintf()
in a placeholder, means that the<code>
tags around thecomposer.json
file name are visible in the release actions:While the most straightforward and sensible thing to do would be to just remove the tags /
sprintf()
, I tried to see if I could unescape them. There may be a simpler way than this messy and non-performant hack, that I stole from here.It works though:
This is the only instance in the code where a JS
sprintf()
call in a template literal is used with a replacement value that includes HTML that should be treated as HTML.