New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObjectIdentifierValue.compareTo() should use numerical comparison #13

Closed
cederberg opened this Issue Jan 28, 2014 · 1 comment

Comments

Projects
None yet
1 participant
@cederberg
Copy link
Owner

cederberg commented Jan 28, 2014

Via email from Matthew Walker:

From Current sorting (since OIDs are treated as Strings) results in inaccuracies like this:

1.3.6.1.2.1.33.1.9.1.0
1.3.6.1.2.1.33.1.9.10.0
1.3.6.1.2.1.33.1.9.2.0

It seems the ObjectIdentifierValue.compareTo() method doesn't perform the proper numerical sorting, but only a simple `toString().compareTo()´.

Oddly enough, it seems that NumberValue.compareTo() is properly implemented with numerical comparison. So it shouldn't be too hard to fix this.

@ghost ghost assigned cederberg Jan 28, 2014

@cederberg cederberg closed this in 68e2847 Jan 28, 2014

@cederberg

This comment has been minimized.

Copy link
Owner

cederberg commented Jan 28, 2014

Also available in 2.10.alpha2 (found at http://www.mibble.org/download/development/index.html)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment