New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MibImporter to return when mib is null. #23

Merged
merged 1 commit into from Jan 27, 2017

Conversation

Projects
None yet
2 participants
@yonghaoy
Copy link
Contributor

yonghaoy commented Jan 27, 2017

Reson for update:
We update 2.10 and had NullPointerException when mib is null. Then the mib loader stops.
Also update javadoc since we don't throw MibException now.

Update MibImporter to return when mib is null.
Reson for update: 
We update 2.10 and had NullPointerException when mib is null. Then the mib loader stops. 
Also update javadoc since we don't throw MibException now.

@cederberg cederberg merged commit da4167a into cederberg:master Jan 27, 2017

@cederberg

This comment has been minimized.

Copy link
Owner

cederberg commented Jan 27, 2017

Yes, indeed. Seems like 09ec6c1 was committed in a bit of a hurry. Thanks for fixing this!

@cederberg

This comment has been minimized.

Copy link
Owner

cederberg commented Jan 27, 2017

BTW. Please update to 1c39f5c or the master branch, since I've added another fix to avoid this NPE. Now also added to the small test suite.

Again. Thanks for reporting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment