Replace Update method with field update methods #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes: - Improve unit tests
joshcody
reviewed
Sep 6, 2019
| Expected: 200, | ||
| Got: resp.StatusCode, | ||
| } | ||
| return nil, fmt.Errorf("Unexpected HTTP response. HTTP status code: %d. Body: %s", resp.StatusCode, resp.Body) |
There was a problem hiding this comment.
Does this line need an error level like the other errors? (like line 106?)
There was a problem hiding this comment.
Good eye! Actually it's the other way around. The convention is to include the log level in calls to log.Printf and log.Println, not in the strings used to create error objects, so I will it on line 106.
| return nil, &UnexpectedHTTPStatusError{ | ||
| Expected: 200, | ||
| Got: resp.StatusCode} | ||
| return nil, fmt.Errorf("Unexpected HTTP response. HTTP status code: %d. Body: %s", resp.StatusCode, resp.Body) |
| Expected: 204, | ||
| Got: resp.StatusCode, | ||
| } | ||
| return fmt.Errorf("Unexpected HTTP response. HTTP status code: %d. Error: %s", resp.StatusCode, err) |
jakewan
commented
Sep 6, 2019
| Expected: 201, | ||
| Got: resp.StatusCode, | ||
| } | ||
| return nil, fmt.Errorf("Unexpected HTTP response. HTTP status code: %d. Body: %s", resp.StatusCode, resp.Body) |
There was a problem hiding this comment.
Removed log level for consistency (log level goes on calls to log.Printf and log.Println).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update is to help support the preferred Terraform pattern of updating resource attributes individually rather than several at once.
Includes improved unit tests.
Tests can be run locally, or in a container (see README.md).
When merged into
master, I'll tag it as v2.0.0, since this breaks the previous public API.