Skip to content

Conversation

@jornh
Copy link
Contributor

@jornh jornh commented Oct 9, 2014

What do you think guys. Should we simply just flick the switch?

@amaitland
Copy link
Member

Stable refers to 1.25.7, will that update when we push to nuget.org?

I'm happy for you to flick the switch!

@jornh
Copy link
Contributor Author

jornh commented Oct 10, 2014

How about we do it together? 😄

Stable refers to 1.25.7, will that update when we push to nuget.org?

It should, one place less to maintain numbers for hopefully more frequent pushes from now on.

If you start by pushing the NuGet packages to nuget proper we'll see if the references update. Btw if you spot any room for README improvements feel free to push to this PR.

@jornh jornh added this to the 33.0.0 milestone Oct 10, 2014
@amaitland
Copy link
Member

How about we do it together? 😄

Sure 😄

I'll push the redist and sdk now as I'm pretty comfortable that they work in VS2012 and VS2013

I'll have a second read over the README and let you know if I can think of anything.

@jornh
Copy link
Contributor Author

jornh commented Oct 10, 2014

👍

@amaitland
Copy link
Member

Both are uploaded 😄

Time to push 33?

@jornh
Copy link
Contributor Author

jornh commented Oct 10, 2014

Yep push away! https://www.nuget.org/packages/cef.redist/ already has 5 downloads

@amaitland
Copy link
Member

https://www.nuget.org/packages/cef.redist/ already has 5 downloads

That's strange! lol

I've uploaded everything, inc the -pre version, so I guess it's official! 😄

@jornh
Copy link
Contributor Author

jornh commented Oct 10, 2014

Just about to test it with MinimalExample a cleared package cache + removed nuget.config + staging.nuget.org disabled in VS

@amaitland
Copy link
Member

Fingers crossed it all goes well!

@jornh
Copy link
Contributor Author

jornh commented Oct 10, 2014

Test seems OK with x86 MinimalExample WinForms as 33.1.0-pre and WPF as 33.0.0 which I used just because that matched my current clone setup.

So I guess next is merge of https://github.com/jornh/CefSharp/blob/doc-bopping/README.md aka PR #508 towards making it official

@amaitland
Copy link
Member

Merge away 😄

jornh added a commit that referenced this pull request Oct 10, 2014
README update for 33.0.0 and 33.1.0-pre01
@jornh jornh merged commit 1b1e311 into cefsharp:master Oct 10, 2014
@jornh jornh deleted the doc-bopping branch October 10, 2014 07:00
@jornh
Copy link
Contributor Author

jornh commented Oct 10, 2014

Next is closing remaining issues on 33.0.0 and making a https://github.com/cefsharp/CefSharp/releases/new do you wan't to do that?

... I'm running for friday-break with breadroll's etc.here at work now. A suiting way to celebrate I think 🎈

@amaitland
Copy link
Member

I've created https://github.com/cefsharp/CefSharp/releases/tag/v33.0.0
Might need a few tweaks. They can wait.

... I'm running for friday-break with breadroll's etc.here at work now. A suiting way to celebrate I think 🎈

Enjoy!

@amaitland amaitland added the cef3 label Oct 10, 2014
@amaitland
Copy link
Member

I've done some of the wiki housekeeping, will look at the rest later 😄

@jornh
Copy link
Contributor Author

jornh commented Oct 10, 2014

Excellent mate! 👍 (Rolls were good)

@amaitland
Copy link
Member

Quite a few downloads already 😄 Hopefully we'll get some feedback soon.

@jornh jornh restored the doc-bopping branch October 10, 2014 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants