Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle deleted artifacts in koji #415

Closed
goldmann opened this issue Mar 1, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@goldmann
Copy link
Contributor

commented Mar 1, 2019

When an artifact is deleted we should not try to fetch it. Instead the build should be terminated.

@goldmann goldmann added this to the 2.2.7 milestone Mar 3, 2019

@goldmann goldmann added type/bug and removed type/enhancement labels Mar 3, 2019

@goldmann goldmann self-assigned this Mar 3, 2019

@goldmann

This comment has been minimized.

Copy link
Contributor Author

commented Mar 4, 2019

To fix this we just need to check the state of the build. Since we already have this information, adding a check is easy.

goldmann added a commit to goldmann/cekit that referenced this issue Mar 4, 2019

Do not download artifacts from unsuccessful builds
We should fetch artifacts only when the build is in COMPLETE state.
In all other cases, build is in incorrect state, we should not fetch
any artifacts in such case.

Fixes cekit#415

goldmann added a commit to goldmann/cekit that referenced this issue Mar 4, 2019

Do not download artifacts from unsuccessful builds
We should fetch artifacts only when the build is in COMPLETE state.
In all other cases, build is in incorrect state, we should not fetch
any artifacts in such case.

Fixes cekit#415

@goldmann goldmann closed this in #417 Mar 4, 2019

goldmann added a commit that referenced this issue Mar 4, 2019

Do not download artifacts from unsuccessful builds
We should fetch artifacts only when the build is in COMPLETE state.
In all other cases, build is in incorrect state, we should not fetch
any artifacts in such case.

Fixes #415

goldmann added a commit to goldmann/cekit that referenced this issue Mar 4, 2019

Do not download artifacts from unsuccessful builds
We should fetch artifacts only when the build is in COMPLETE state.
In all other cases, build is in incorrect state, we should not fetch
any artifacts in such case.

Fixes cekit#415
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.