Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for APK package manager #609

Closed
cvgaviao opened this issue Sep 3, 2019 · 4 comments · Fixed by #612

Comments

@cvgaviao
Copy link

@cvgaviao cvgaviao commented Sep 3, 2019

Describe the solution you'd like
I would like to use Cekit to build images using Alpine Linux as its base image. But Alpine uses APK as its packages manager that currently is not supported by Cekit.

@goldmann

This comment has been minimized.

Copy link
Contributor

@goldmann goldmann commented Sep 4, 2019

Thanks for this report! It should be doable to add support for Alpine fairly easy, I hope. Let me investigate it. I'll schedule it afterwards.

@goldmann goldmann added this to To do in Release 3.5 via automation Sep 4, 2019
@goldmann goldmann added this to the 3.5.0 milestone Sep 4, 2019
@goldmann

This comment has been minimized.

Copy link
Contributor

@goldmann goldmann commented Sep 4, 2019

Scheduling for next release.

@goldmann goldmann moved this from To do to In progress in Release 3.5 Sep 4, 2019
@goldmann goldmann self-assigned this Sep 4, 2019
goldmann added a commit to goldmann/cekit that referenced this issue Sep 4, 2019
This adds support for apk package manager used in Alpine Linux.

Fixes cekit#609
goldmann added a commit to goldmann/cekit that referenced this issue Sep 4, 2019
This adds support for apk package manager used in Alpine Linux.

Additionally changes execution of module install scripts from
hardcoded to 'bash' to 'sh' to ensure that scripts can be run
in images without Bash available.

Fixes cekit#609
goldmann added a commit to goldmann/cekit that referenced this issue Sep 4, 2019
This adds support for apk package manager used in Alpine Linux.

Additionally changes execution of module install scripts from
hardcoded to 'bash' to 'sh' to ensure that scripts can be run
in images without Bash available.

Fixes cekit#609
@goldmann

This comment has been minimized.

Copy link
Contributor

@goldmann goldmann commented Sep 18, 2019

Sadly, I need to move this into next release. It looks like there is big demand to release 3.5 very soon and I still haven't finished the PR for this ticket. It's in works, but there are a few things that needs to be ironed still. Moving to 3.6.

@goldmann goldmann modified the milestones: 3.5.0, 3.6.0 Sep 18, 2019
@goldmann goldmann removed this from In progress in Release 3.5 Sep 18, 2019
@goldmann goldmann added this to To do in Release 3.6 via automation Sep 18, 2019
@goldmann goldmann moved this from To do to In progress in Release 3.6 Sep 25, 2019
goldmann added a commit to goldmann/cekit that referenced this issue Sep 25, 2019
This adds support for apk package manager used in Alpine Linux.

Additionally changes execution of module install scripts from
hardcoded to 'bash' to 'sh' to ensure that scripts can be run
in images without Bash available.

Fixes cekit#609
@goldmann

This comment has been minimized.

Copy link
Contributor

@goldmann goldmann commented Sep 25, 2019

This change will require switching from bash to sh for executing module scripts, but I don't think this will affect anyone, because in almost all cases sh is a symlink to bash.

CentOS 7:

[root@d82648b51043 bin]# ll /usr/bin/sh
lrwxrwxrwx. 1 root root 4 Aug  1 01:09 /usr/bin/sh -> bash

Fedora 30:

[root@fa99bdfa171a /]# ll /usr/bin/sh
lrwxrwxrwx. 1 root root 4 May 13 12:18 /usr/bin/sh -> bash

UBI 8:

bash-4.4# ls -hal /usr/bin/sh
lrwxrwxrwx. 1 root root 4 Jan 14  2019 /usr/bin/sh -> bash

Alpine 3.10:

/ # ls -hal /bin/sh 
lrwxrwxrwx    1 root     root          12 Aug 20 10:30 /bin/sh -> /bin/busybox

Alpine is a new kid on the block so it doesn't count :)

Release 3.6 automation moved this from In progress to Done Sep 25, 2019
goldmann added a commit that referenced this issue Sep 25, 2019
This adds support for apk package manager used in Alpine Linux.

Additionally changes execution of module install scripts from
hardcoded to 'bash' to 'sh' to ensure that scripts can be run
in images without Bash available.

Fixes #609
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Release 3.6
  
Done
2 participants
You can’t perform that action at this time.