Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI rewrite #412

Merged
merged 21 commits into from Mar 7, 2019

Conversation

Projects
None yet
2 participants
@goldmann
Copy link
Contributor

commented Feb 26, 2019

Fixes #364

Show resolved Hide resolved cekit/cli.py

@goldmann goldmann force-pushed the goldmann:gh-364-cli-rewrite branch from fae1bdd to 41ce36f Feb 27, 2019

@@ -18,3 +18,4 @@ docs/_build
*.egg-info
.vscode
Pipfile.lock
venv

This comment has been minimized.

Copy link
@rnc

rnc Mar 2, 2019

Contributor

Shouldn't this be .venv?

This comment has been minimized.

Copy link
@goldmann

goldmann Mar 2, 2019

Author Contributor

I use the venv directory for my virtualenvs. I can change it though.

This comment has been minimized.

Copy link
@rnc

rnc Mar 2, 2019

Contributor

Ah! Apologies, its because I was adding .venv (for https://github.com/MichaelAquilina/zsh-autoswitch-virtualenv/) and thought you were doing similar. No worries.

This comment has been minimized.

Copy link
@goldmann

goldmann Mar 2, 2019

Author Contributor

I can move to this convention. Seems to be cleaner to have it in a "hidden" directory.

Show resolved Hide resolved cekit/builders/buildah.py Outdated
Show resolved Hide resolved cekit/builders/osbs.py
Show resolved Hide resolved cekit/cli.py
Show resolved Hide resolved cekit/builders/docker_builder.py Outdated
@rnc

This comment has been minimized.

Copy link
Contributor

commented Mar 2, 2019

Really nice restructure , impressive piece of work 👍

@goldmann goldmann force-pushed the goldmann:gh-364-cli-rewrite branch from 4452019 to ab15f12 Mar 5, 2019

goldmann added some commits Mar 5, 2019

@goldmann goldmann marked this pull request as ready for review Mar 5, 2019

@goldmann goldmann requested a review from rnc Mar 5, 2019

@goldmann goldmann referenced this pull request Mar 5, 2019

Closed

Review caching #361

4 of 4 tasks complete
@rnc

rnc approved these changes Mar 7, 2019

Copy link
Contributor

left a comment

LGTM!

@goldmann

This comment has been minimized.

Copy link
Contributor Author

commented Mar 7, 2019

Thanks!

@goldmann goldmann merged commit 24ae8ac into cekit:develop Mar 7, 2019

1 of 2 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
ci/circleci Your tests passed on CircleCI!
Details

@goldmann goldmann deleted the goldmann:gh-364-cli-rewrite branch Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.