From 997de5db2058068f3606fcf0013b0e99a17b88fa Mon Sep 17 00:00:00 2001 From: Tomer Nosrati Date: Fri, 21 Oct 2022 00:50:01 +0300 Subject: [PATCH] Stabilized test_mutable_errback_called_by_chord_from_group_fail_multiple --- t/integration/test_canvas.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/t/integration/test_canvas.py b/t/integration/test_canvas.py index 33ed392944b..c5f16b71150 100644 --- a/t/integration/test_canvas.py +++ b/t/integration/test_canvas.py @@ -2472,6 +2472,7 @@ def test_immutable_errback_called_by_chord_from_group_fail_multiple( await_redis_count(fail_task_count, redis_key=redis_key) redis_connection.delete(redis_key) + @flaky @pytest.mark.parametrize( "errback_task", [errback_old_style, errback_new_style, ], ) @@ -2482,7 +2483,7 @@ def test_mutable_errback_called_by_chord_from_group_fail_multiple( raise pytest.skip("Requires redis result backend.") redis_connection = get_redis_connection() - fail_task_count = 42 + fail_task_count = 14 # We have to use failing task signatures with unique task IDs to ensure # the chord can complete when they are used as part of its header! fail_sigs = tuple( @@ -2492,7 +2493,7 @@ def test_mutable_errback_called_by_chord_from_group_fail_multiple( errback = errback_task.s() # Include a mix of passing and failing tasks child_sig = group( - *(identity.si(42) for _ in range(24)), # arbitrary task count + *(identity.si(42) for _ in range(8)), # arbitrary task count *fail_sigs, ) @@ -2502,7 +2503,7 @@ def test_mutable_errback_called_by_chord_from_group_fail_multiple( redis_connection.delete(expected_redis_key) with subtests.test(msg="Error propagates from header group"): res = chord_sig.delay() - sleep(1) + sleep(2) with pytest.raises(ExpectedException): res.get(timeout=TIMEOUT) with subtests.test(msg="Errback is called after header group fails"): @@ -2516,7 +2517,7 @@ def test_mutable_errback_called_by_chord_from_group_fail_multiple( redis_connection.delete(fail_sig_id) with subtests.test(msg="Error propagates from body group"): res = chord_sig.delay() - sleep(1) + sleep(2) with pytest.raises(ExpectedException): res.get(timeout=TIMEOUT) with subtests.test(msg="Errback is called after body group fails"):