New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better cleanup of dead processes. #1834

Merged
merged 6 commits into from Jan 31, 2014

Conversation

Projects
None yet
3 participants
@ionelmc
Copy link
Member

ionelmc commented Jan 30, 2014

This should fix #1785. Still testing it tho ...

@@ -966,7 +973,7 @@ def on_process_alive(self, pid):
try:
proc = next(w for w in self._pool if w.pid == pid)
except StopIteration:
# process already exited :( this will be handled elsewhere.
logger.critical("process with pid=%s already exited :( this will be handled elsewhere.", pid)

This comment has been minimized.

@ask

ask Jan 30, 2014

Member

Should this be logged?

This comment has been minimized.

@ionelmc

ionelmc Jan 30, 2014

Member

I added this to help with debugging #1785. I still think we should have it (it could indicate other problems).

This comment has been minimized.

@ask

ask Jan 30, 2014

Member

Right, I suspected that. It cannot be considered critical at least if it's automatically handled.

@ionelmc

This comment has been minimized.

Copy link
Member

ionelmc commented Jan 30, 2014

Allright, changed to warning.

Btw, no issues so far ... running for 2h with no issue.

@ionelmc

This comment has been minimized.

Copy link
Member

ionelmc commented Jan 30, 2014

Damn, it crashed again... after 7745 seconds. The log is a bit big, I'm pasting the last part: https://gist.github.com/ionelmc/8709531

I've used a slightly modified kombu that has extra logging: https://github.com/ionelmc/kombu/compare/fix-1785?expand=1

@ionelmc

This comment has been minimized.

Copy link
Member

ionelmc commented Jan 30, 2014

Running for 3 hours with no issues with the last fix.

@ionelmc

This comment has been minimized.

Copy link
Member

ionelmc commented Jan 31, 2014

12h and no issues :)

ionelmc added a commit that referenced this pull request Jan 31, 2014

Merge pull request #1834 from ionelmc/fix-1785
Better cleanup of dead processes.

@ionelmc ionelmc merged commit a40ea20 into celery:master Jan 31, 2014

@ionelmc ionelmc deleted the ionelmc:fix-1785 branch Jan 31, 2014

@rogerhu

This comment has been minimized.

Copy link
Contributor

rogerhu commented on d3674b6 Feb 8, 2014

Will there be another release soon? We're waiting anxiously to upgrade because of this commit. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment