Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix request expiration timezone #2224
Conversation
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Sep 8, 2014
This comment has been minimized.
This comment has been minimized.
|
Thanks! Merged into master and 3.1 Please also add your name to https://github.com/celery/celery/edit/master/CONTRIBUTORS.txt |
ask
closed this
Oct 28, 2014
albertyw
deleted the
albertyw:fix-request-expiration-timezone
branch
Oct 29, 2014
This comment has been minimized.
This comment has been minimized.
|
@ask May I ask when the next celery release will be? I'd like to switch our python requirements file to point to the official PyPI version once this pull request has been released. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
albertyw commentedAug 30, 2014
I was getting errors while trying to turn on time zone support for Django and Celery. I believe this fix makes
nowandself.expiresalways be both time zone aware or time zone unaware so that they can be compared.This is basically #1885 turned into a pull request.