New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix request expiration timezone #2224

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@albertyw
Contributor

albertyw commented Aug 30, 2014

I was getting errors while trying to turn on time zone support for Django and Celery. I believe this fix makes now and self.expires always be both time zone aware or time zone unaware so that they can be compared.

This is basically #1885 turned into a pull request.

@coveralls

This comment has been minimized.

coveralls commented Sep 8, 2014

Coverage Status

Coverage remained the same when pulling 1c1242a on albertyw:fix-request-expiration-timezone into ef382f8 on celery:master.

@ask

This comment has been minimized.

Member

ask commented Oct 28, 2014

Thanks! Merged into master and 3.1

Please also add your name to https://github.com/celery/celery/edit/master/CONTRIBUTORS.txt

@ask ask closed this Oct 28, 2014

@albertyw albertyw deleted the albertyw:fix-request-expiration-timezone branch Oct 29, 2014

@albertyw albertyw referenced this pull request Oct 29, 2014

Merged

Update CONTRIBUTORS.txt #2342

@albertyw

This comment has been minimized.

Contributor

albertyw commented Nov 9, 2014

@ask May I ask when the next celery release will be? I'd like to switch our python requirements file to point to the official PyPI version once this pull request has been released. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment