[WIP] import from asynchronous instead of async and fix python 3.7 compat issues #4679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
commented
Apr 24, 2018
|
should I address only import related issues in this pr? and other 3.7 related issues in another one? |
|
Please rename the PR and resolve all Python 3.7 related issues. |
auvipy
changed the title
Closed
|
I'm going to merge this anyway since we need this. I'm not sure why the build fails. |
thedrow
pushed a commit
that referenced
this pull request
May 21, 2018
…mpat issues (#4679) * imported from renamed asynchronous module of kombu * imported from renamed asynchronous module of kombu * imported from renamed asynchronous module of kombu in utils timer2 * update minimum kombu version
rajadain
added a commit
to WikiWatershed/model-my-watershed
that referenced
this pull request
May 21, 2018
Latest Kombu renamed async to asynchronous celery/kombu#839 breaking Celery, which has a PR to fix this celery/celery#4679 but the changes haven't been released yet celery/celery#4387 so we use this in the interim.
SebastianBerchtold
pushed a commit
to smartlane/celery
that referenced
this pull request
Jun 11, 2018
…mpat issues (celery#4679) * imported from renamed asynchronous module of kombu * imported from renamed asynchronous module of kombu * imported from renamed asynchronous module of kombu in utils timer2 * update minimum kombu version
deeTEEcee
pushed a commit
to sightmachine/celery
that referenced
this pull request
Sep 11, 2018
…mpat issues (celery#4679) * imported from renamed asynchronous module of kombu * imported from renamed asynchronous module of kombu * imported from renamed asynchronous module of kombu in utils timer2 * update minimum kombu version
|
@auvipy Could we also apply this to celery 3.1.25? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work to fix #4500