Enable configcheck lint step to be run in docker#4687
Merged
auvipy merged 1 commit intocelery:masterfrom Apr 28, 2018
CatalystCode:fix-configcheck-in-docker
Merged
Enable configcheck lint step to be run in docker#4687auvipy merged 1 commit intocelery:masterfrom CatalystCode:fix-configcheck-in-docker
auvipy merged 1 commit intocelery:masterfrom
CatalystCode:fix-configcheck-in-docker
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4687 +/- ##
=======================================
Coverage 82.52% 82.52%
=======================================
Files 140 140
Lines 15894 15894
Branches 1980 1980
=======================================
Hits 13116 13116
Misses 2586 2586
Partials 192 192Continue to review full report at Codecov.
|
auvipy
approved these changes
Apr 28, 2018
Contributor
|
@c-w thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently the configcheck lint step can't be run in the Celery Docker container (see screenshot of error message below) which makes it harder to easily verify all the lint steps locally.
This pull request makes it possible to run the configcheck lint step with one Docker command: