Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable configcheck lint step to be run in docker #4687

Merged
merged 1 commit into from Apr 28, 2018

Conversation

Projects
None yet
3 participants
@c-w
Copy link
Contributor

commented Apr 27, 2018

Description

Currently the configcheck lint step can't be run in the Celery Docker container (see screenshot of error message below) which makes it harder to easily verify all the lint steps locally.

Screenshot of configcheck failure

This pull request makes it possible to run the configcheck lint step with one Docker command:

docker-compose run -e TOXENV=configcheck --rm celery tox
@codecov

This comment has been minimized.

Copy link

commented Apr 27, 2018

Codecov Report

Merging #4687 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4687   +/-   ##
=======================================
  Coverage   82.52%   82.52%           
=======================================
  Files         140      140           
  Lines       15894    15894           
  Branches     1980     1980           
=======================================
  Hits        13116    13116           
  Misses       2586     2586           
  Partials      192      192

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa636bc...e74b337. Read the comment docs.

@auvipy

auvipy approved these changes Apr 28, 2018

@auvipy auvipy merged commit 0c277bb into celery:master Apr 28, 2018

4 checks passed

codecov/patch Coverage not affected when comparing aa636bc...e74b337
Details
codecov/project 82.52% remains the same compared to aa636bc
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@georgepsarakis

This comment has been minimized.

Copy link
Member

commented Apr 28, 2018

@c-w thank you for your contribution!

@c-w c-w deleted the CatalystCode:fix-configcheck-in-docker branch Apr 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.