Skip to content

Enable configcheck lint step to be run in docker#4687

Merged
auvipy merged 1 commit intocelery:masterfrom
CatalystCode:fix-configcheck-in-docker
Apr 28, 2018
Merged

Enable configcheck lint step to be run in docker#4687
auvipy merged 1 commit intocelery:masterfrom
CatalystCode:fix-configcheck-in-docker

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Apr 27, 2018

Description

Currently the configcheck lint step can't be run in the Celery Docker container (see screenshot of error message below) which makes it harder to easily verify all the lint steps locally.

Screenshot of configcheck failure

This pull request makes it possible to run the configcheck lint step with one Docker command:

docker-compose run -e TOXENV=configcheck --rm celery tox

@codecov
Copy link

codecov bot commented Apr 27, 2018

Codecov Report

Merging #4687 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4687   +/-   ##
=======================================
  Coverage   82.52%   82.52%           
=======================================
  Files         140      140           
  Lines       15894    15894           
  Branches     1980     1980           
=======================================
  Hits        13116    13116           
  Misses       2586     2586           
  Partials      192      192

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa636bc...e74b337. Read the comment docs.

@auvipy auvipy merged commit 0c277bb into celery:master Apr 28, 2018
@georgepsarakis
Copy link
Contributor

@c-w thank you for your contribution!

@c-w c-w deleted the fix-configcheck-in-docker branch April 28, 2018 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants