Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker-compose start error #4691

Merged
merged 1 commit into from Apr 30, 2018

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Contributor

commented Apr 30, 2018

Description

Running docker-compose on a clean checkout currently fails with a validation error that services.celery.build.args contains null.

Screenshot of docker-compose error due to missing build argument

Referencing the CELERY_USER environment variable defined in .env does not fix this since environment variables are only applied at container run-time, not build-time. To avoid potential confusion due to this, it's easiest to just hard-code the CELERY_USER variable in the docker-compose file.

Fix docker-compose start error
Running docker-compose on a clean checkout currently fails with a
validation error that `services.celery.build.args` contains null.
Referencing the `CELERY_USER` environment variable defined in `.env`
does not fix this since environment variables are only applied at
container run-time, not build-time. To avoid potential confusion due to
this, it's easiest to just hard-code the `CELERY_USER` variable in the
docker-compose file.
@auvipy

auvipy approved these changes Apr 30, 2018

@codecov

This comment has been minimized.

Copy link

commented Apr 30, 2018

Codecov Report

Merging #4691 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #4691   +/-   ##
======================================
  Coverage    82.6%   82.6%           
======================================
  Files         140     140           
  Lines       15868   15868           
  Branches     1983    1983           
======================================
  Hits        13107   13107           
  Misses       2567    2567           
  Partials      194     194

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2cfc87...6aa616c. Read the comment docs.

@auvipy auvipy merged commit c04effc into celery:master Apr 30, 2018

4 checks passed

codecov/patch Coverage not affected when comparing c2cfc87...6aa616c
Details
codecov/project 82.6% remains the same compared to c2cfc87
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@auvipy auvipy added this to the v4.2 milestone Apr 30, 2018

@c-w c-w deleted the CatalystCode:fix-docker-start-error branch Apr 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.