Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added compatibility with python 3.7 #4902

Merged
merged 1 commit into from Jul 12, 2018

Conversation

@kidoz
Copy link
Contributor

kidoz commented Jul 12, 2018

In Python 3.7 removed re._pattern_type, see python/cpython#1646. Now in 3.7 need using re.Pattern instead it.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jul 12, 2018

Codecov Report

Merging #4902 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4902      +/-   ##
==========================================
+ Coverage   82.87%   82.88%   +0.01%     
==========================================
  Files         140      140              
  Lines       15949    15951       +2     
  Branches     1997     1997              
==========================================
+ Hits        13217    13221       +4     
+ Misses       2534     2533       -1     
+ Partials      198      197       -1
Impacted Files Coverage Δ
celery/app/routes.py 95.83% <100%> (+2.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e700276...3c68cd4. Read the comment docs.

Copy link
Member

auvipy left a comment

could you increase coverage?

@kidoz kidoz force-pushed the kidoz:hotfix/compatibility-with-3.7 branch 2 times, most recently from 6854b5c to e983284 Jul 12, 2018
@kidoz

This comment has been minimized.

Copy link
Contributor Author

kidoz commented Jul 12, 2018

Done.
Only:
code-quality/landscape - 500 error

@kidoz

This comment has been minimized.

Copy link
Contributor Author

kidoz commented Jul 12, 2018

image

@kidoz kidoz force-pushed the kidoz:hotfix/compatibility-with-3.7 branch from e983284 to 3c68cd4 Jul 12, 2018
@auvipy

This comment has been minimized.

Copy link
Member

auvipy commented Jul 12, 2018

ignore landscape

@auvipy
auvipy approved these changes Jul 12, 2018
@auvipy auvipy merged commit 1c3a159 into celery:master Jul 12, 2018
4 of 5 checks passed
4 of 5 checks passed
code-quality/landscape Landscape has completed the code quality check
Details
codecov/patch 100% of diff hit (target 82.87%)
Details
codecov/project 82.88% (+0.01%) compared to e700276
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dfresh613 added a commit to dfresh613/celery that referenced this pull request Jul 21, 2018
dfresh613 added a commit to dfresh613/celery that referenced this pull request Jul 21, 2018
robertknight added a commit to hypothesis/h that referenced this pull request Jul 23, 2018
This doesn't resolve all Python 3.7 issues. A Celery release with the following
PRs is still awaited:

 - celery/celery#4902
 - celery/celery#4852
robertknight added a commit to hypothesis/h that referenced this pull request Jul 24, 2018
This doesn't resolve all Python 3.7 issues. A Celery release with the following
PRs is still awaited:

 - celery/celery#4902
 - celery/celery#4852
deeTEEcee added a commit to sightmachine/celery that referenced this pull request Sep 11, 2018
@genofire genofire mentioned this pull request Sep 17, 2018
jesse-sempre added a commit to semprehealth/celery that referenced this pull request Oct 18, 2018
novocaine added a commit to Memrise/celery that referenced this pull request Nov 28, 2018
novocaine added a commit to Memrise/celery that referenced this pull request Nov 28, 2018
Photonios added a commit to SectorLabs/celery that referenced this pull request Jan 8, 2019
# Conflicts:
#	celery/app/routes.py
yevhen-m added a commit to getgoing/celery that referenced this pull request Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.