Use string values for django-cache keys #230 #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When django cache backend tests the key provided by django_celery_results, It wants to have str type value.
byte values result in the following exception being raised:
File "/opt/exaboard/eXaboard/lib/python3.6/site-packages/django/core/cache/backends/base.py", line 287, in memcache_key_warnings
if ord(char) < 33 or ord(char) == 127:
TypeError: ord() expected string of length 1, but int found
for more information, see https://pre-commit.ci
auvipy
requested changes
Oct 11, 2021
|
@auvipy , please have a look if the test added provides sufficient coverage |
auvipy
approved these changes
Oct 11, 2021
|
thanks a lot for finding it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes #230
When django cache backend tests the key provided by django_celery_results, It wants to have str type value.
byte values result in the following exception being raised:
File "/opt/exaboard/eXaboard/lib/python3.6/site-packages/django/core/cache/backends/base.py", line 287, in memcache_key_warnings
if ord(char) < 33 or ord(char) == 127:
TypeError: ord() expected string of length 1, but int found