Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also .

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also .
Choose a Base Repository
celery/kombu
1stvamp/kombu
AlfiyaZi/kombu
BenjaminDavison/kombu
Bernie/kombu
CNXTEoEorg/kombu
CrazyLionHeart/kombu
EnTeQuAk/kombu
Ephemera/kombu
GetResQ/kombu
Kronuz/kombu
LeonLv/kombu
MyBook/kombu
RagnarDanneskjold/kombu
TriggeredMessaging/kombu
U-238/kombu
WhiskeyMedia/kombu
WoLpH/kombu
ZoranPavlovic/kombu
abourget/kombu
aburan28/kombu
aclowes/kombu
adityar7/kombu
akashacn/kombu
alanjds/kombu
alex/kombu
amscanne/kombu
andresriancho/kombu
andviro/kombu
antong/kombu
aromanovich/kombu
ask/kombu
atodorov/kombu
ayoshi/kombu
beav/kombu
benauthor/kombu
bettlebrox/kombu
blaze33/kombu
bmbouter/kombu
bradjasper/kombu
c-nichols/kombu
cce/kombu
cjerdonek/kombu
coagulant/kombu
coolcoding/kombu
crozzy/kombu
daevaorn/kombu
daftshady/kombu
daneguempel/kombu
danostrowski/kombu
dariobottazzi/kombu
darkseas/kombu
dat-boris/kombu
datoug/kombu
daviddeng/kombu
dctrwatson/kombu
desterkin/kombu
disqus/kombu
djmitche/kombu
dlamotte/kombu
dmtaub/kombu
dnene/kombu
doismellburning/kombu
dziegler/kombu
emrahayanoglu/kombu
erhuabushuo/kombu
ericbuehl/kombu
feifangit/kombu
firemyst/kombu
flaper87/kombu
floppya/kombu
fongandrew/kombu
freshguy/kombu
frewsxcv/kombu
ginoledesma/kombu
gnomix/kombu
gpmidi/kombu
grahamc/kombu
greghaskins/kombu
gtaylor/kombu
guasek/kombu
harlowja/kombu
hellerstanislav/kombu
hungld/kombu
ianrclark/kombu
idbentley/kombu
idealopamp/kombu
ieure/kombu
ionelmc/kombu
j00bar/kombu
jamesls/kombu
jcalazan/kombu
jcsp/kombu
jedestep/kombu
jesper/kombu
jessedhillon/kombu
jfroche/kombu
jhalcrow/kombu
jlafon/kombu
johtso/kombu
jonmorehouse/kombu
jshuping/kombu
jsullivanlive/kombu
jtillman/kombu
karvin/kombu
kevin1024/kombu
kirk91/kombu
kkung/kombu
kmarkow/kombu
kryskool/kombu
lifeeth/kombu
liorsion/kombu
lokistone/kombu
mahendra/kombu
mans0954/kombu
mathom/kombu
max8899/kombu
mayfield/kombu
mbroten/kombu
metzlar/kombu
minisin/kombu
mixedpuppy/kombu
mjaszczyk/kombu
mlavin/kombu
mrjj/kombu
n1ywb/kombu
naemono/kombu
nexiles/kombu
nimrodm/kombu
nitzanm/kombu
nvie/kombu
nvkgrandhi/kombu
olliewalsh/kombu
osamu0329nakamura/kombu
pantheon-systems/kombu
pbhowmic/kombu
pegler/kombu
peterlundberg/kombu
pipistrelo/kombu
pombredanne/kombu
priteau/kombu
psquarejho/kombu
public/kombu
rafaduran/kombu
ramavarsh/kombu
rczajka/kombu
rdavl/kombu
rectalogic/kombu
reynolek/kombu
rhcarvalho/kombu
ridethepony/kombu
rlotun/kombu
romand/kombu
rumineykova/kombu
ryandub/kombu
ryanpetrello/kombu
samstav/kombu
saschpe/kombu
schecbr/kombu
scottpersinger/kombu
sebasmagri/kombu
sebinsua/kombu
sebleier/kombu
sibblegp/kombu
simplegeo/kombu
singingwolfboy/kombu
skovorodkin/kombu
skyl/kombu
slyons/kombu
splee/kombu
spoqa/kombu
sprintly/kombu
spulec/kombu
suoluoji/kombu
szaydel/kombu
tahmmee/kombu
tempbottle/kombu
tewfik/kombu
theflow/kombu
tliron/kombu
tobych/kombu
topbrands/kombu
treyhunner/kombu
treytabner/kombu
tschellenbach/kombu
tsuyukimakoto/kombu
ttddyy/kombu
tumb1er/kombu
ulricheck/kombu
usrlocalben/kombu
vail130/kombu
vicenteg/kombu
victorgp/kombu
victorpoluceno/kombu
vlad-belogrudov/kombu
wetneb/kombu
xando/kombu
yosh/kombu
zmsmith/kombu
zmullett/kombu
Nothing to show
Choose a Head Repository
celery/kombu
1stvamp/kombu
AlfiyaZi/kombu
BenjaminDavison/kombu
Bernie/kombu
CNXTEoEorg/kombu
CrazyLionHeart/kombu
EnTeQuAk/kombu
Ephemera/kombu
GetResQ/kombu
Kronuz/kombu
LeonLv/kombu
MyBook/kombu
RagnarDanneskjold/kombu
TriggeredMessaging/kombu
U-238/kombu
WhiskeyMedia/kombu
WoLpH/kombu
ZoranPavlovic/kombu
abourget/kombu
aburan28/kombu
aclowes/kombu
adityar7/kombu
akashacn/kombu
alanjds/kombu
alex/kombu
amscanne/kombu
andresriancho/kombu
andviro/kombu
antong/kombu
aromanovich/kombu
ask/kombu
atodorov/kombu
ayoshi/kombu
beav/kombu
benauthor/kombu
bettlebrox/kombu
blaze33/kombu
bmbouter/kombu
bradjasper/kombu
c-nichols/kombu
cce/kombu
cjerdonek/kombu
coagulant/kombu
coolcoding/kombu
crozzy/kombu
daevaorn/kombu
daftshady/kombu
daneguempel/kombu
danostrowski/kombu
dariobottazzi/kombu
darkseas/kombu
dat-boris/kombu
datoug/kombu
daviddeng/kombu
dctrwatson/kombu
desterkin/kombu
disqus/kombu
djmitche/kombu
dlamotte/kombu
dmtaub/kombu
dnene/kombu
doismellburning/kombu
dziegler/kombu
emrahayanoglu/kombu
erhuabushuo/kombu
ericbuehl/kombu
feifangit/kombu
firemyst/kombu
flaper87/kombu
floppya/kombu
fongandrew/kombu
freshguy/kombu
frewsxcv/kombu
ginoledesma/kombu
gnomix/kombu
gpmidi/kombu
grahamc/kombu
greghaskins/kombu
gtaylor/kombu
guasek/kombu
harlowja/kombu
hellerstanislav/kombu
hungld/kombu
ianrclark/kombu
idbentley/kombu
idealopamp/kombu
ieure/kombu
ionelmc/kombu
j00bar/kombu
jamesls/kombu
jcalazan/kombu
jcsp/kombu
jedestep/kombu
jesper/kombu
jessedhillon/kombu
jfroche/kombu
jhalcrow/kombu
jlafon/kombu
johtso/kombu
jonmorehouse/kombu
jshuping/kombu
jsullivanlive/kombu
jtillman/kombu
karvin/kombu
kevin1024/kombu
kirk91/kombu
kkung/kombu
kmarkow/kombu
kryskool/kombu
lifeeth/kombu
liorsion/kombu
lokistone/kombu
mahendra/kombu
mans0954/kombu
mathom/kombu
max8899/kombu
mayfield/kombu
mbroten/kombu
metzlar/kombu
minisin/kombu
mixedpuppy/kombu
mjaszczyk/kombu
mlavin/kombu
mrjj/kombu
n1ywb/kombu
naemono/kombu
nexiles/kombu
nimrodm/kombu
nitzanm/kombu
nvie/kombu
nvkgrandhi/kombu
olliewalsh/kombu
osamu0329nakamura/kombu
pantheon-systems/kombu
pbhowmic/kombu
pegler/kombu
peterlundberg/kombu
pipistrelo/kombu
pombredanne/kombu
priteau/kombu
psquarejho/kombu
public/kombu
rafaduran/kombu
ramavarsh/kombu
rczajka/kombu
rdavl/kombu
rectalogic/kombu
reynolek/kombu
rhcarvalho/kombu
ridethepony/kombu
rlotun/kombu
romand/kombu
rumineykova/kombu
ryandub/kombu
ryanpetrello/kombu
samstav/kombu
saschpe/kombu
schecbr/kombu
scottpersinger/kombu
sebasmagri/kombu
sebinsua/kombu
sebleier/kombu
sibblegp/kombu
simplegeo/kombu
singingwolfboy/kombu
skovorodkin/kombu
skyl/kombu
slyons/kombu
splee/kombu
spoqa/kombu
sprintly/kombu
spulec/kombu
suoluoji/kombu
szaydel/kombu
tahmmee/kombu
tempbottle/kombu
tewfik/kombu
theflow/kombu
tliron/kombu
tobych/kombu
topbrands/kombu
treyhunner/kombu
treytabner/kombu
tschellenbach/kombu
tsuyukimakoto/kombu
ttddyy/kombu
tumb1er/kombu
ulricheck/kombu
usrlocalben/kombu
vail130/kombu
vicenteg/kombu
victorgp/kombu
victorpoluceno/kombu
vlad-belogrudov/kombu
wetneb/kombu
xando/kombu
yosh/kombu
zmsmith/kombu
zmullett/kombu
Nothing to show
  • 1 commit
  • 1 file changed
  • 0 commit comments
  • 1 contributor
Commits on Feb 26, 2017
Adds `multiple` kwarg to Qpid `Channel.basic_ack` (#700)
Celery 4.0.2 passes the `multiple` keyword argument to `basic_ack`.
This did not used to occur with 3.1.20- so this change is only being
merged into the 4.0 branch. The desired functionality of this param is
documented here [0], but the Qpid transport uses UUIDs as the
delivery_tags so we don't have a record of the sequential messages
required to implement this. We use UUIDs as the deliver_tag to avoid
Issue #563.

With the functionality for the `multiple` parameter not implemented, an
AssertionError is raised if Celery attempts to meaningfully use the
`multiple` parameter with the Qpid transport. A developer or user who
encounters this AssertionError should file a bug with Kombu.

[0] http://amqp.readthedocs.io/en/latest/reference/amqp.connection.html#amqp.connection.Connection.Channel.basic_ack

closes #699
Showing with 5 additions and 1 deletion.
  1. +5 −1 kombu/transport/qpid.py
View
@@ -850,7 +850,7 @@ def basic_get(self, queue, no_ack=False, **kwargs):
except Empty:
pass
def basic_ack(self, delivery_tag):
def basic_ack(self, delivery_tag, multiple=False):
"""Acknowledge a message by delivery_tag.
Acknowledges a message referenced by delivery_tag. Messages can
@@ -864,8 +864,12 @@ def basic_ack(self, delivery_tag):
:param delivery_tag: The delivery tag associated with the message
to be acknowledged.
:type delivery_tag: uuid.UUID
:param multiple: not implemented. If set to True an AssertionError
is raised.
:type multiple: bool
"""
assert multiple is False
self.qos.ack(delivery_tag)
def basic_reject(self, delivery_tag, requeue=False):

No commit comments for this range