reduce memory usage of Transport #1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawl
commented
Dec 21, 2021
kombu/transport/virtual/base.py
Outdated
| self.channel_id = self.connection._avail_channel_ids.pop() | ||
| except IndexError: | ||
| # Cast to a set for fast lookups, and keep stored as an array for lower memory usage. | ||
| used_channel_ids = set(self.connection._used_channel_ids) |
There was a problem hiding this comment.
Maybe we should put this _used_channel_ids stuff into its own method like it is in py-amqp?: https://github.com/celery/py-amqp/blob/6433be13199938f47bbc2826e6585e746baf4f9b/amqp/connection.py#L484-L492
There was a problem hiding this comment.
if that improves the codebase you could give it a try
There was a problem hiding this comment.
Ok, I went ahead and made this change: a439ada
|
also can you and your team please check the two open PR in pyamqp with this two PR in kombu & celery that nothing create any regression? I like your efforts very much, just being too cautious as it's holiday season coming. |
auvipy
approved these changes
Dec 23, 2021
2 tasks
keithgg
pushed a commit
to open-craft/kombu
that referenced
this pull request
Aug 11, 2022
* reduce memory usage of Transport * fix flake8 errors * move channel_id login into _get_free_channel_id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating a redis broker memory leak, I noticed the same issue as py-amqp's #377:
The array that's used to store available connection ids is taking up an unnecessary amount of memory (more than anything else while running celery), and it's making memory leaks worse.
This PR reduces the memory usage of the
Transportby reversing that logic and turning_avail_channel_idsinto_used_channel_ids. This will only store the channel ids that are currently used, which is almost always going to be a much smaller array.