624 convert qpid to amqp 1.0 #810
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice work, looking forward for final review |
bmbouter
force-pushed
the
624-convert-qpid-to-amqp-1.0
branch
3 times, most recently
from
df7a08d
to
9f2fd40
Compare
bmbouter
force-pushed
the
624-convert-qpid-to-amqp-1.0
branch
from
6035c32
to
ac43cc6
Compare
daviddavis
reviewed
Nov 9, 2017
kombu/transport/qpid.py
Outdated
|
|
||
| PY3 = sys.version_info[0] == 3 | ||
|
|
||
| StartConsumer = namedtuple('StartConsumer', ['queue']) |
There was a problem hiding this comment.
I think a comment here would help to describe what these named tuples are for.
There was a problem hiding this comment.
Great idea. I just pushed a change with docstrings for each object type.
bmbouter
force-pushed
the
624-convert-qpid-to-amqp-1.0
branch
from
8eb8303
to
0038711
Compare
added 12 commits
January 12, 2018 12:34
Still working on basic_consume(), but everything else should work.
* Adds error raising in MainThread. * Removes several Channel methods so there is less to maintain * Pass in connection options and store them for the async connect * Many docstring improvements
It works with Pulp.
The workaround is already built in all the places this dependency will provided so this is safe to remove.
Also adds reconnect support for the QMF BrokerAgent Connection.
The objects used to pass "commands" between MainThread and ProtonThread had no documentation. This fixes that, and also renames one of them for clarity. Also added an else: clause where I saw it made sense to do that.
bmbouter
force-pushed
the
624-convert-qpid-to-amqp-1.0
branch
from
0038711
to
ebfc436
Compare
dparalen
added a commit
to dparalen/pulp
that referenced
this pull request
Feb 14, 2018
Since Pulp still won't run with vanilla qpid broker[1] it seems reasonable to refer to the RabbitMQ as the default broker instead. Fixes pulp#3366 https://pulp.plan.io/issues/3366 [1] celery/kombu#810
dparalen
added a commit
to dparalen/pulp
that referenced
this pull request
Mar 12, 2018
Since Pulp still won't run with vanilla qpid broker[1] it seems reasonable to refer to the RabbitMQ as the default broker instead. Fixes pulp#3366 https://pulp.plan.io/issues/3366 [1] celery/kombu#810
|
/rebase |
|
The rebase failed: To rebase manually, run these commands in your terminal: # Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/rebase 624-convert-qpid-to-amqp-1.0
# Navigate to the new directory.
cd .worktrees/rebase
# Rebase and resolve the likely conflicts.
git rebase --interactive --autosquash master
# Push the new branch state to GitHub.
git push --force
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/rebase |
auvipy
reviewed
Dec 13, 2020
| qpid-python>=0.26 | ||
| qpid-tools>=0.26 | ||
| python-qpid-proton | ||
| qpid-tools |
There was a problem hiding this comment.
i get this error while trying to install qpid-tools File "/tmp/pip-install-9104bo_x/qpid-python_a14df52a368846c0b0474e8c8647e96c/setup.py", line 42
raise DistutilsFileError,
^
SyntaxError: invalid syntax
----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to see what the test runners said about the code I have. I had developed it against 3.0. All of the unit tests pass locally, but sometimes the PR test runners point out other issues.
I will rebase onto 4.0 soon and switch the target branch to 4.0 later. I don't plan to merge this to the 3.0 branch.