Fix breaking change in Azure ServiceBus SDK - #998
Conversation
|
NB: the Travis build is failing due to lint errors in files that were not changed by this pull request: Perhaps someone could look into this, perhaps @georgepsarakis or @auvipy who helped with the Azure support pull requests in the past? Thanks in advance! |
|
would you mind fixing the flake8 error? |
|
I'll take a look at the lint errors. |
|
@thedrow would you mind considering a RC release of kombu and celery 4.3 any time soon? if not you could document the release process with bumpversion so others can also contribute to the release process? |
|
Most of the lint errors are due to PyCQA/pyflakes#373. |
Codecov Report
@@ Coverage Diff @@
## master #998 +/- ##
=======================================
Coverage 88.59% 88.59%
=======================================
Files 63 63
Lines 6549 6549
Branches 781 781
=======================================
Hits 5802 5802
Misses 664 664
Partials 83 83Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #998 +/- ##
=======================================
Coverage 88.59% 88.59%
=======================================
Files 63 63
Lines 6549 6549
Branches 781 781
=======================================
Hits 5802 5802
Misses 664 664
Partials 83 83Continue to review full report at Codecov.
|
The Azure ServiceBus SDK upgrade from version 0.21.1 to 0.50.0 introduced a breaking change which affects the
azureservicebus://transport. This pull request makes kombu compatible with both old and new versions of the SDK. See the Azure ServiceBus SDK release notes for more background.