Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breaking change in Azure ServiceBus SDK #998

Merged
merged 1 commit into from Feb 4, 2019
Merged

Fix breaking change in Azure ServiceBus SDK #998

merged 1 commit into from Feb 4, 2019

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Feb 4, 2019

The Azure ServiceBus SDK upgrade from version 0.21.1 to 0.50.0 introduced a breaking change which affects the azureservicebus:// transport. This pull request makes kombu compatible with both old and new versions of the SDK. See the Azure ServiceBus SDK release notes for more background.

@c-w
Copy link
Contributor Author

@c-w c-w commented Feb 4, 2019

NB: the Travis build is failing due to lint errors in files that were not changed by this pull request: time.py, text.py, url.py, base.py, and test_timer.py. Not sure what's going on.

Perhaps someone could look into this, perhaps @georgepsarakis or @auvipy who helped with the Azure support pull requests in the past? Thanks in advance!

Loading

auvipy
auvipy approved these changes Feb 4, 2019
@auvipy
Copy link
Member

@auvipy auvipy commented Feb 4, 2019

would you mind fixing the flake8 error?

Loading

@thedrow
Copy link
Member

@thedrow thedrow commented Feb 4, 2019

I'll take a look at the lint errors.

Loading

@auvipy
Copy link
Member

@auvipy auvipy commented Feb 4, 2019

@thedrow would you mind considering a RC release of kombu and celery 4.3 any time soon? if not you could document the release process with bumpversion so others can also contribute to the release process?

Loading

@thedrow
Copy link
Member

@thedrow thedrow commented Feb 4, 2019

Most of the lint errors are due to PyCQA/pyflakes#373.
Fixing...

Loading

@codecov
Copy link

@codecov codecov bot commented Feb 4, 2019

Codecov Report

Merging #998 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #998   +/-   ##
=======================================
  Coverage   88.59%   88.59%           
=======================================
  Files          63       63           
  Lines        6549     6549           
  Branches      781      781           
=======================================
  Hits         5802     5802           
  Misses        664      664           
  Partials       83       83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4f239c...e415158. Read the comment docs.

Loading

1 similar comment
@codecov
Copy link

@codecov codecov bot commented Feb 4, 2019

Codecov Report

Merging #998 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #998   +/-   ##
=======================================
  Coverage   88.59%   88.59%           
=======================================
  Files          63       63           
  Lines        6549     6549           
  Branches      781      781           
=======================================
  Hits         5802     5802           
  Misses        664      664           
  Partials       83       83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4f239c...e415158. Read the comment docs.

Loading

@thedrow thedrow merged commit ec05b6e into celery:master Feb 4, 2019
4 checks passed
Loading
@c-w c-w deleted the fix-azure-servicebus-sdk-change branch Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants