Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breaking change in Azure ServiceBus SDK #998

Merged
merged 1 commit into from Feb 4, 2019

Conversation

Projects
None yet
3 participants
@c-w
Copy link
Contributor

commented Feb 4, 2019

The Azure ServiceBus SDK upgrade from version 0.21.1 to 0.50.0 introduced a breaking change which affects the azureservicebus:// transport. This pull request makes kombu compatible with both old and new versions of the SDK. See the Azure ServiceBus SDK release notes for more background.

@c-w

This comment has been minimized.

Copy link
Contributor Author

commented Feb 4, 2019

NB: the Travis build is failing due to lint errors in files that were not changed by this pull request: time.py, text.py, url.py, base.py, and test_timer.py. Not sure what's going on.

Perhaps someone could look into this, perhaps @georgepsarakis or @auvipy who helped with the Azure support pull requests in the past? Thanks in advance!

@auvipy

auvipy approved these changes Feb 4, 2019

@auvipy

This comment has been minimized.

Copy link
Member

commented Feb 4, 2019

would you mind fixing the flake8 error?

@thedrow

This comment has been minimized.

Copy link
Member

commented Feb 4, 2019

I'll take a look at the lint errors.

@auvipy

This comment has been minimized.

Copy link
Member

commented Feb 4, 2019

@thedrow would you mind considering a RC release of kombu and celery 4.3 any time soon? if not you could document the release process with bumpversion so others can also contribute to the release process?

@thedrow

This comment has been minimized.

Copy link
Member

commented Feb 4, 2019

Most of the lint errors are due to PyCQA/pyflakes#373.
Fixing...

@codecov

This comment has been minimized.

Copy link

commented Feb 4, 2019

Codecov Report

Merging #998 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #998   +/-   ##
=======================================
  Coverage   88.59%   88.59%           
=======================================
  Files          63       63           
  Lines        6549     6549           
  Branches      781      781           
=======================================
  Hits         5802     5802           
  Misses        664      664           
  Partials       83       83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4f239c...e415158. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Feb 4, 2019

Codecov Report

Merging #998 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #998   +/-   ##
=======================================
  Coverage   88.59%   88.59%           
=======================================
  Files          63       63           
  Lines        6549     6549           
  Branches      781      781           
=======================================
  Hits         5802     5802           
  Misses        664      664           
  Partials       83       83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4f239c...e415158. Read the comment docs.

@thedrow thedrow merged commit ec05b6e into celery:master Feb 4, 2019

4 checks passed

codecov/patch Coverage not affected when comparing b4f239c...e415158
Details
codecov/project 88.59% remains the same compared to b4f239c
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@c-w c-w deleted the CatalystCode:fix-azure-servicebus-sdk-change branch Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.