Skip to content

Fix breaking change in Azure ServiceBus SDK - #998

Merged
thedrow merged 1 commit into
celery:masterfrom
CatalystCode:fix-azure-servicebus-sdk-change
Feb 4, 2019
Merged

thedrow merged 1 commit into
celery:masterfrom
CatalystCode:fix-azure-servicebus-sdk-change

Conversation

@c-w

@c-w c-w commented Feb 4, 2019

Copy link
Copy Markdown
Contributor

The Azure ServiceBus SDK upgrade from version 0.21.1 to 0.50.0 introduced a breaking change which affects the azureservicebus:// transport. This pull request makes kombu compatible with both old and new versions of the SDK. See the Azure ServiceBus SDK release notes for more background.

@c-w

c-w commented Feb 4, 2019

Copy link
Copy Markdown
Contributor Author

NB: the Travis build is failing due to lint errors in files that were not changed by this pull request: time.py, text.py, url.py, base.py, and test_timer.py. Not sure what's going on.

Perhaps someone could look into this, perhaps @georgepsarakis or @auvipy who helped with the Azure support pull requests in the past? Thanks in advance!

@auvipy

auvipy commented Feb 4, 2019

Copy link
Copy Markdown
Member

would you mind fixing the flake8 error?

@thedrow

thedrow commented Feb 4, 2019

Copy link
Copy Markdown

I'll take a look at the lint errors.

@auvipy

auvipy commented Feb 4, 2019

Copy link
Copy Markdown
Member

@thedrow would you mind considering a RC release of kombu and celery 4.3 any time soon? if not you could document the release process with bumpversion so others can also contribute to the release process?

@thedrow

thedrow commented Feb 4, 2019

Copy link
Copy Markdown

Most of the lint errors are due to PyCQA/pyflakes#373.
Fixing...

@codecov

codecov Bot commented Feb 4, 2019

Copy link
Copy Markdown

Codecov Report

Merging #998 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #998   +/-   ##
=======================================
  Coverage   88.59%   88.59%           
=======================================
  Files          63       63           
  Lines        6549     6549           
  Branches      781      781           
=======================================
  Hits         5802     5802           
  Misses        664      664           
  Partials       83       83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4f239c...e415158. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Feb 4, 2019

Copy link
Copy Markdown

Codecov Report

Merging #998 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #998   +/-   ##
=======================================
  Coverage   88.59%   88.59%           
=======================================
  Files          63       63           
  Lines        6549     6549           
  Branches      781      781           
=======================================
  Hits         5802     5802           
  Misses        664      664           
  Partials       83       83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4f239c...e415158. Read the comment docs.

@c-w
c-w deleted the fix-azure-servicebus-sdk-change branch February 4, 2019 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants