Support for Python 3 #13

thijstriemstra · Dec 13, 2012

It would be nice to support Python 3 at some point. Getting this error at the moment when running python3.3 setup.py build:

File "setup.py", line 185
    except Exception, exc:
                ^
SyntaxError: invalid syntax

Yeah, Python 3 support is planned, but it would most likely also require changes at the C level

ask · Dec 17, 2012

Yeah, Python 3 support is planned, but it would most likely also require changes at the C level

Same issue here - enclosed is a larger stack trace:

Downloading/unpacking librabbitmq (from -r /home/christian/documents/projects/rh/requirements.txt (line 41))
  Downloading librabbitmq-1.0.2.tar.gz (455kB): 455kB downloaded
  Running setup.py egg_info for package librabbitmq
    Traceback (most recent call last):
      File "<string>", line 16, in <module>
      File "/tmp/pip_build_christian/librabbitmq/setup.py", line 185
        except Exception, exc:
                        ^
    SyntaxError: invalid syntax
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):

  File "<string>", line 16, in <module>

  File "/tmp/pip_build_christian/librabbitmq/setup.py", line 185

    except Exception, exc:

                    ^

SyntaxError: invalid syntax

----------------------------------------
Cleaning up...
Command python setup.py egg_info failed with error code 1 in /tmp/pip_build_christian/librabbitmq
Storing complete log in /home/christian/.pip/pip.log

jensenbox · Nov 9, 2013

Same issue here - enclosed is a larger stack trace:

Downloading/unpacking librabbitmq (from -r /home/christian/documents/projects/rh/requirements.txt (line 41))
  Downloading librabbitmq-1.0.2.tar.gz (455kB): 455kB downloaded
  Running setup.py egg_info for package librabbitmq
    Traceback (most recent call last):
      File "<string>", line 16, in <module>
      File "/tmp/pip_build_christian/librabbitmq/setup.py", line 185
        except Exception, exc:
                        ^
    SyntaxError: invalid syntax
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):

  File "<string>", line 16, in <module>

  File "/tmp/pip_build_christian/librabbitmq/setup.py", line 185

    except Exception, exc:

                    ^

SyntaxError: invalid syntax

----------------------------------------
Cleaning up...
Command python setup.py egg_info failed with error code 1 in /tmp/pip_build_christian/librabbitmq
Storing complete log in /home/christian/.pip/pip.log

Any schedule for 3 support?

uschen · Nov 14, 2013

Any schedule for 3 support?

Not yet. Need to port the C code too and I haven't even looked at the changes in the Python 3 C API.

ask · Nov 15, 2013

Not yet. Need to port the C code too and I haven't even looked at the changes in the Python 3 C API.

Have the same problem with 1.0.3

kamikaze · Dec 4, 2013

Have the same problem with 1.0.3

Thanks for a great library!
+1 for Py3.

w3iBStime · Mar 14, 2014

Thanks for a great library!
+1 for Py3.

From initial digging, it looks like it'll need, among other things(?):

#if PY_MAJOR_VERSION >=3
#  define Py_TPFLAGS_HAVE_ITER 0
#endif

https://mail.python.org/pipermail/python-porting/2012-April/000289.html

Adding PyTypeObject *ob_type; to PyRabbitMQ_Connection (via the PyObject_HEAD_INIT macro? http://docs.python.org/3.3/c-api/typeobj.html)

...and some changes related to string encoding (everything is unicode under Py3). E.g.,

PyString_FromString -> PyUnicode_FromString
PyString_AsString -> PyUnicode_AsEncodedString

2to3 appears to take care of most of the Python code.

w3iBStime · Mar 14, 2014

From initial digging, it looks like it'll need, among other things(?):

#if PY_MAJOR_VERSION >=3
#  define Py_TPFLAGS_HAVE_ITER 0
#endif

https://mail.python.org/pipermail/python-porting/2012-April/000289.html

Adding PyTypeObject *ob_type; to PyRabbitMQ_Connection (via the PyObject_HEAD_INIT macro? http://docs.python.org/3.3/c-api/typeobj.html)

...and some changes related to string encoding (everything is unicode under Py3). E.g.,

PyString_FromString -> PyUnicode_FromString
PyString_AsString -> PyUnicode_AsEncodedString

2to3 appears to take care of most of the Python code.

+1 for py3

jbonfante · Apr 2, 2014

+1 for py3

+1

timdawborn · Apr 9, 2014

+1

kamikaze · Apr 25, 2014

+1

bosr · May 6, 2014

+1

sgeoffrey · May 27, 2014

+1

Ditto. I'd love to see Python 3 support!

synthead · May 30, 2014

Ditto. I'd love to see Python 3 support!

+1

adampl · Jun 3, 2014

+1

@ask

@ask What do you think about converting the bindings to CFFI so that Python 3 bindings would be possible and PyPy would be supported?

omerzimp · Jun 10, 2014

@ask What do you think about converting the bindings to CFFI so that Python 3 bindings would be possible and PyPy would be supported?

+1

davidfischer-ch · Jun 10, 2014

+1

@omerzimp

@omerzimp I don't know how powerful CFFI is, and if that is possible, but that is something I have been considering. I doubt I would have the time to do so anytime soon though.

ask · Jun 10, 2014

@omerzimp I don't know how powerful CFFI is, and if that is possible, but that is something I have been considering. I doubt I would have the time to do so anytime soon though.

+1

Last thing holding me back from porting my stuff across to Python 3 entirely!

Xiol · Jun 12, 2014

+1

Last thing holding me back from porting my stuff across to Python 3 entirely!

@Xiol

@Xiol : If you can live with the performance, py-amqp (https://pypi.python.org/pypi/amqp/) is compatible with Python 3.

I also had to work around an issue with heartbeats since my consumers are long-running (the work-around is available here: celery/py-amqp#37 (comment))

w3iBStime · Jun 12, 2014

@Xiol : If you can live with the performance, py-amqp (https://pypi.python.org/pypi/amqp/) is compatible with Python 3.

I also had to work around an issue with heartbeats since my consumers are long-running (the work-around is available here: celery/py-amqp#37 (comment))

+1

glyphobet · Jul 24, 2014

+1

hwkns · Aug 30, 2014

+1

One more voice wishing for Python 3 support

hovissimo · Sep 8, 2014

One more voice wishing for Python 3 support

+1

vitaly4uk · Oct 24, 2014

+1

ngonzalvez · Nov 17, 2014

+1

+1000

jsalvet · Nov 19, 2014

+1000

+1

littlezz · Dec 23, 2014

+1

Oh what the heck, +1

grahamc · Feb 17, 2015

Oh what the heck, +1

+1

dwieeb · Feb 18, 2015

+1

zloy531 · Feb 23, 2015

+1

+1 for Python3

gavinmh · Feb 23, 2015

+1 for Python3

+1

r-darwish · Mar 11, 2015

+1

mark-adams · Mar 13, 2015

+1

mstajdohar · Mar 19, 2015

+1

Made a first attempt at this here.

dgelvin · Mar 25, 2015

Made a first attempt at this here.

+1

iyn · Apr 21, 2015

+1

aidanlister · May 10, 2015

+1

underyx · May 12, 2015

+1

btoueg · Jun 10, 2015

+1

mastak · Jun 15, 2015

+1

ajutras · Jun 18, 2015

+1

anthraxx · Jun 24, 2015

+1

arthurk · Jul 24, 2015

+1

I think it is enough of "+1"s. I'm going to lock this issue not because we won't add python 3 support, but to avoid messing up our mailboxes.

If anybody of "+1"ers have some time, please spend it on creating pull requests for python 3 support. Thank you.

malinoff · Jul 24, 2015

I think it is enough of "+1"s. I'm going to lock this issue not because we won't add python 3 support, but to avoid messing up our mailboxes.

If anybody of "+1"ers have some time, please spend it on creating pull requests for python 3 support. Thank you.

@ask

@ask @malinoff I am gonna tackle this issue to support python3

auvipy · Aug 6, 2016

@ask @malinoff I am gonna tackle this issue to support python3

I think the next step would be to improve the test suite. We especially need to test the Connection object and its methods return types.

berkerpeksag · Aug 9, 2016

I think the next step would be to improve the test suite. We especially need to test the Connection object and its methods return types.

Finally fixed. :)

thedrow · May 30, 2018

Finally fixed. :)

adampl referenced this issue Jan 19, 2015
Closed
invalid (python 3) syntax in setup.py #64

thijstriemstra referenced this issue Mar 25, 2015
Closed
fix Python 3 syntax error in setup.py #50

thedrow referenced this issue Jun 20, 2015
Closed
Celery Kickstarter Ideas #2655
0 of 21 tasks complete

satterly referenced this issue Jun 30, 2015
Merged
Support both Python 2.7 and Python 3.x #100

celery locked and limited conversation to collaborators Jul 24, 2015

auvipy self-assigned this Aug 6, 2016

thedrow closed this May 30, 2018

celery/librabbitmq

Join GitHub today

Support for Python 3 #13

Comments

thijstriemstra commented Dec 13, 2012

This comment has been minimized.

ask commented Dec 17, 2012

This comment has been minimized.

jensenbox commented Nov 9, 2013

This comment has been minimized.

uschen commented Nov 14, 2013

This comment has been minimized.

ask commented Nov 15, 2013

This comment has been minimized.

kamikaze commented Dec 4, 2013

This comment has been minimized.

w3iBStime commented Mar 14, 2014

This comment has been minimized.

w3iBStime commented Mar 14, 2014

This comment has been minimized.

jbonfante commented Apr 2, 2014

This comment has been minimized.

timdawborn commented Apr 9, 2014

This comment has been minimized.

kamikaze commented Apr 25, 2014

This comment has been minimized.

bosr commented May 6, 2014

This comment has been minimized.

sgeoffrey commented May 27, 2014

This comment has been minimized.

synthead commented May 30, 2014

This comment has been minimized.

adampl commented Jun 3, 2014

This comment has been minimized.

omerzimp commented Jun 10, 2014

This comment has been minimized.

davidfischer-ch commented Jun 10, 2014

This comment has been minimized.

ask commented Jun 10, 2014

This comment has been minimized.

Xiol commented Jun 12, 2014

This comment has been minimized.

w3iBStime commented Jun 12, 2014

This comment has been minimized.

glyphobet commented Jul 24, 2014

This comment has been minimized.

hwkns commented Aug 30, 2014

This comment has been minimized.

hovissimo commented Sep 8, 2014

This comment has been minimized.

vitaly4uk commented Oct 24, 2014

This comment has been minimized.

ngonzalvez commented Nov 17, 2014

This comment has been minimized.

jsalvet commented Nov 19, 2014

This comment has been minimized.

littlezz commented Dec 23, 2014

adampl referenced this issue Jan 19, 2015

This comment has been minimized.

grahamc commented Feb 17, 2015

This comment has been minimized.

dwieeb commented Feb 18, 2015

This comment has been minimized.

zloy531 commented Feb 23, 2015

This comment has been minimized.

gavinmh commented Feb 23, 2015

This comment has been minimized.

r-darwish commented Mar 11, 2015

This comment has been minimized.

mark-adams commented Mar 13, 2015

This comment has been minimized.

mstajdohar commented Mar 19, 2015

This comment has been minimized.

dgelvin commented Mar 25, 2015

thijstriemstra referenced this issue Mar 25, 2015

This comment has been minimized.

iyn commented Apr 21, 2015

This comment has been minimized.

aidanlister commented May 10, 2015

This comment has been minimized.

auvipy commented Aug 6, 2016 •

edited