From 8ae29dcec8239a96eb29513ca81114c0091a6c92 Mon Sep 17 00:00:00 2001 From: Vlad Date: Wed, 19 Apr 2023 16:14:48 +0300 Subject: [PATCH] review suggestions --- share/p2p/peers/pool.go | 6 +++--- share/p2p/shrexnd/client.go | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/share/p2p/peers/pool.go b/share/p2p/peers/pool.go index f82c936719..bcf425a475 100644 --- a/share/p2p/peers/pool.go +++ b/share/p2p/peers/pool.go @@ -12,7 +12,7 @@ const defaultCleanupThreshold = 2 // pool stores peers and provides methods for simple round-robin access. type pool struct { - m sync.Mutex + m sync.RWMutex peersList []peer.ID statuses map[peer.ID]status cooldown *timedQueue @@ -196,7 +196,7 @@ func (p *pool) checkHasPeers() { } func (p *pool) size() int { - p.m.Lock() - defer p.m.Unlock() + p.m.RLock() + defer p.m.RUnlock() return p.activeCount } diff --git a/share/p2p/shrexnd/client.go b/share/p2p/shrexnd/client.go index 910bf88f1b..78af04e61b 100644 --- a/share/p2p/shrexnd/client.go +++ b/share/p2p/shrexnd/client.go @@ -69,7 +69,7 @@ func (c *Client) RequestND( } } if err != p2p.ErrNotFound { - log.Warnw("client: peer returned err", "err", err) + log.Warnw("client-nd: peer returned err", "err", err) } return nil, err }