Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include flatpak manifest in repository for easy cross-distro building #435

Open
BrainBlasted opened this issue May 25, 2019 · 8 comments · May be fixed by #449

Comments

@BrainBlasted
Copy link

commented May 25, 2019

Hey there - I would love to do some work on Celluloid, but the thing preventing me from getting started is that I can't build it in GNOME Builder without hunting down all the dependencies manually. Within upstream GNOME we have a process that includes having a flatpak manifest in the repo, so when cloned by Builder (or other IDEs with flatpak support) building and running is always as simple as pressing a button. This makes it much easier to get started contributing to applications, and makes testing new things simple as well.

Would you be interested in having a manifest in the repo? If so I'll put in the work to get one working :)

@gnome-mpv

This comment has been minimized.

Copy link
Collaborator

commented May 25, 2019

Actually, we already have two working flatpak manifests. One for tarball releases in the flathub repo and another one that uses the git repo directly.

@BrainBlasted

This comment has been minimized.

Copy link
Author

commented May 25, 2019

Yes, the thing I'm requesting is about one within the repo - so when I clone celluloid in Builder it can grab all the dependencies and I can run a sandboxed development version.

@BrainBlasted

This comment has been minimized.

Copy link
Author

commented May 25, 2019

Typically these use the master GNOME runtime and build everything from git rather than tagged releases.

@gnome-mpv

This comment has been minimized.

Copy link
Collaborator

commented May 25, 2019

Yes, the thing I'm requesting is about one within the repo - so when I clone celluloid in Builder it can grab all the dependencies and I can run a sandboxed development version.

Wouldn't downloading one from a different repo achieve the same result?

@BrainBlasted

This comment has been minimized.

Copy link
Author

commented May 25, 2019

No - GNOME Builder requires a local checkout in the same repo as the manifest in order to build and run it. This is because it runs the final build steps itself for integration & iteration purposes.

@gnome-mpv

This comment has been minimized.

Copy link
Collaborator

commented May 25, 2019

Alright, please go ahead and submit a pull request when you're ready.

@BrainBlasted

This comment has been minimized.

Copy link
Author

commented May 25, 2019

Alright, will try and get this done later today :)

BrainBlasted added a commit to BrainBlasted/celluloid that referenced this issue Jul 23, 2019
This allows for Celluloid to be built in one click from
apps like GNOME Builder - without installing dependencies
manually.

Closes celluloid-player#435
@BrainBlasted

This comment has been minimized.

Copy link
Author

commented Jul 23, 2019

It took me a lot longer to get back to this than I expected, but I submitted a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.