Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Celluloid::IO::SSLSocket.accept ? #39

Closed
codekitchen opened this Issue Jan 23, 2013 · 6 comments

Comments

Projects
None yet
3 participants
Contributor

codekitchen commented Jan 23, 2013

I added this method to a WIP project i'm dabbling with, is it something you want in Celluloid::IO proper? If so I can put together a pull request with some tests.

https://github.com/codekitchen/tkellem/blob/celluloid/lib/tkellem/celluloid_tools.rb#L32

The advantage of putting the SSL accept on the socket, rather than having a Celluloid::IO::SSLServer is that you can send data on the socket before "upgrading" it to SSL, STARTTLS style. It'd be convenient to add a SSLServer class as well, that calls accept on the SSL socket immediately on connection.

Member

benlangfeld commented Jan 23, 2013

+1

Owner

tarcieri commented Jan 23, 2013

Well, this is sort of close, but it should really be Celluloid::IO::SSLServer

Contributor

codekitchen commented Jan 23, 2013

did you see my comment? it makes a lot of sense to support upgrading an existing socket to ssl, i think a convenience Celluloid::IO::SSLServer should be built on top of accept support in Celluloid::IO::SSLSocket.

Owner

tarcieri commented Jan 23, 2013

Makes sense, sorry did a quick glance over ;)

Contributor

codekitchen commented Jan 23, 2013

cool, i'll try to find time to put together a pull request soon then

Contributor

codekitchen commented Jan 25, 2013

pull request at #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment