Raise ECONNRESET if socket#gets returns nil #5

Merged
merged 4 commits into from Mar 31, 2013

Conversation

Projects
None yet
3 participants
Contributor

simonrobson commented Mar 31, 2013

Follows ruby driver approach. Fixes #4

Coverage increased (+0.64%) when pulling 5edac62 on simonrobson:read_should_raise_on_eof into cd952a1 on celluloid:master.

View Details

@simonrobson simonrobson test for clean shutdown
Infrastructure for testing against a new redis instance.
ddb853a

Coverage increased (+8.61%) when pulling ddb853a on simonrobson:read_should_raise_on_eof into cd952a1 on celluloid:master.

View Details

Owner

tarcieri commented Mar 31, 2013

You almost had it ;) Looks like ddb853a breaks the build on JRuby

Coverage remained the same when pulling 6b57abf on simonrobson:read_should_raise_on_eof into cd952a1 on celluloid:master.

View Details

Contributor

simonrobson commented Mar 31, 2013

Latest commit fixes that on jruby 1.7.3.

The problem was in the test helper which spawns a new instance of redis to test against. Which introduced its own timing issues. Think the latest version is more solid. Though not yet sure if this is the best way to test things like shutdown.

tarcieri merged commit b5ff966 into celluloid:master Mar 31, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment