Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Library appears to initialize and clean up when not explicitly instantiated #94

Closed
tboyko opened this Issue Sep 20, 2012 · 6 comments

Comments

Projects
None yet
3 participants

tboyko commented Sep 20, 2012

A simple script like this:

require 'celluloid'

outputs the following upon execution/exit:

I, [2012-09-20T11:34:13.727047 #13173]  INFO -- : Terminating 2 actors...
I, [2012-09-20T11:34:13.727431 #13173]  INFO -- : Shutdown completed cleanly

Shouldn't requiring a library be a fairly passive action, meaning that nothing should be initialized or cleaned up unless an object is created from that library?

Owner

tarcieri commented Sep 20, 2012

I could try to separate Celluloid initialization so it occurs somewhat lazily, but that's actually quite difficult and something I'm not really interested in doing in the near future. Put it on your post-Celluloid 1.0 wish list.

You're not the first person to complain about this, but I'm calling it "won't fix" at least for now. I definitely prefer having the logger automatically activate.

@tarcieri tarcieri closed this Sep 20, 2012

I'm seeing this as well after adding a library that uses Celluloid to my app (Sidekiq). Now I get emails for every Cron job that runs on my server, even if the job itself does not output anything, the "Terminating..." message is always printed out. Very annoying! Can I silence Celluloid somehow?

Owner

tarcieri commented Nov 16, 2012

See #112. Also 04f2820 moves those messages to the debug loglevel, so you should be able to adjust the logging severity if you so desire.

And as always, you can redirect the log to a logfile by setting Celluloid.logger to something else (e.g. nil)

Great! Could you release a new gem version with 04f2820?

tboyko commented Nov 29, 2012

I second @manuelmeurer's request. Please release a new gem including this change!

Owner

tarcieri commented Nov 29, 2012

There's some other stuff I need to finish up before the next release. This is coming soon, though! ;)

@Soliah Soliah referenced this issue in mperham/sidekiq Jun 3, 2013

Closed

Shutdown completed cleanly messages #975

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment