Fix thread safety issue when closing Selector #9

Merged
merged 1 commit into from Oct 28, 2012

2 participants

@dbussink

Fixes #8

@dbussink dbussink referenced this pull request in rubinius/rubinius Oct 27, 2012
Closed

Segfault on ruby_ami specs #1822

@dbussink

@tarcieri Can this fix be merged or does it need additional work? This could cause deadlocks when calling close, not sure if that's how you want to approach it? Another idea would be just to set closed to true and wakeup the event loop. Then the loop could cleanup it's own stuff instead of having shutdown do that.

@tarcieri
Celluloid member

@dbussink not sure why the build is breaking but it seems unrelated. Overall this looks good to me. Guess I'll go ahead and merge it and see if I can figure out the build failures.

@tarcieri tarcieri merged commit 0448c5b into celluloid:master Oct 28, 2012

1 check failed

Details default The Travis build failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment