New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ping method on WebSocket driver. #187

Open
digitalextremist opened this Issue Apr 8, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@digitalextremist
Member

digitalextremist commented Apr 8, 2015

As requested in kenichi/angelo#52: add a forwardable delegator for ping to @driver.

@kenichi

This comment has been minimized.

Show comment
Hide comment
@kenichi

kenichi Apr 8, 2015

Member

or maybe just add :driver to the attr_accessor list?

Member

kenichi commented Apr 8, 2015

or maybe just add :driver to the attr_accessor list?

@digitalextremist

This comment has been minimized.

Show comment
Hide comment
@digitalextremist

digitalextremist Apr 8, 2015

Member

@kenichi that's a possibility, I'd need to think about that. I'm leaning toward this being more of a duck type and abstraction layer, rather than encouraging people to directly access the driver and become dependent on driver-specific code some day.

Will ponder while also resolving #186, but currently over in Celluloid itself for a bit.

Member

digitalextremist commented Apr 8, 2015

@kenichi that's a possibility, I'd need to think about that. I'm leaning toward this being more of a duck type and abstraction layer, rather than encouraging people to directly access the driver and become dependent on driver-specific code some day.

Will ponder while also resolving #186, but currently over in Celluloid itself for a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment