Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI issue on celo-monorepo yarn install #1094

Merged
merged 1 commit into from Jul 2, 2020

Conversation

bowd
Copy link
Contributor

@bowd bowd commented Jul 2, 2020

Description

Some recent change to celo-monorepo introduced dependencies that need to be installed from github over ssh and thus we need to add and verify the github.com ssh keys in order to avoid the classic:

The authenticity of host 'github.com (140.82.113.3)' can't be established.
RSA key fingerprint is SHA256:nThbg6kXUpJWGl7E1IGCspRomTxdCARLviKw6E5SY8.
Are you sure you want to continue connecting (yes/no)? 

Props to @valer-cara for some help with the ssh-fu

@bowd bowd requested review from asaj and timmoreton as code owners July 2, 2020 11:28
@bowd bowd force-pushed the bowd/fix-monorepo-ci-install branch 2 times, most recently from ad0ff90 to d552fdb Compare July 2, 2020 11:32
@bowd bowd force-pushed the bowd/fix-monorepo-ci-install branch from d552fdb to 379950e Compare July 2, 2020 11:37
@bowd bowd requested a review from jeanregisser July 2, 2020 11:43
Copy link
Contributor

@mrsmkl mrsmkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the CI!

@mrsmkl mrsmkl merged commit be7b606 into master Jul 2, 2020
@mrsmkl mrsmkl deleted the bowd/fix-monorepo-ci-install branch July 2, 2020 13:29
Comment on lines +139 to +141
set -e
mkdir ~/.ssh && ssh-keyscan github.com >> ~/.ssh/known_hosts
ssh-keygen -F github.com -l -f ~/.ssh/known_hosts | grep 'github.com RSA ${GITHUB_RSA_FINGERPRINT}' && echo "Github key verification successful"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need set -e -o pipefail
also single quotes prevent variable substitution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants