Add Nashorn test runner. #65

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@mikesperber

This adds a test runner for Nashorn, essentially porting the Rhino runner.

@cemerick

This comment has been minimized.

Show comment Hide comment
@cemerick

cemerick Jun 24, 2014

Owner

Thanks. I'll get this folded in shortly, which will allow me to make some headway in nailing down the other nashorn-related issues you've filed.

Owner

cemerick commented Jun 24, 2014

Thanks. I'll get this folded in shortly, which will allow me to make some headway in nailing down the other nashorn-related issues you've filed.

@cemerick

This comment has been minimized.

Show comment Hide comment
@cemerick

cemerick Dec 11, 2014

Owner

Definitely interested in this, but want to see it passing tests before looking at it seriously. Also, if you could squash down to a single commit, that'd be great. Thanks!

Owner

cemerick commented Dec 11, 2014

Definitely interested in this, but want to see it passing tests before looking at it seriously. Also, if you could squash down to a single commit, that'd be great. Thanks!

@cemerick cemerick removed this from the 0.3.2 milestone Dec 11, 2014

@mikesperber

This comment has been minimized.

Show comment Hide comment
@mikesperber

mikesperber Dec 17, 2014

Done. (Note that the async problems from #67 remain.)

Done. (Note that the async problems from #67 remain.)

@cemerick

This comment has been minimized.

Show comment Hide comment
@cemerick

cemerick Dec 17, 2014

Owner

Some of the test commands use nashorn, some use jrunscript; the docs refer to the latter, and the former doesn't exist AFAICT in my install of JDK 8. Can you disambiguate?

Owner

cemerick commented Dec 17, 2014

Some of the test commands use nashorn, some use jrunscript; the docs refer to the latter, and the former doesn't exist AFAICT in my install of JDK 8. Can you disambiguate?

@mikesperber

This comment has been minimized.

Show comment Hide comment
@mikesperber

mikesperber Dec 17, 2014

jrunscript is the standard script to invoke nashorn. I've never had "nashorn" - I believe this may have existed on development previews, but it's definitely not relevant.

jrunscript is the standard script to invoke nashorn. I've never had "nashorn" - I believe this may have existed on development previews, but it's definitely not relevant.

project.clj
+ "-f" :nashorn-runner
+ "target/cljs/whitespace.js"
+ "test/cemerick/cljs/test/extra_test_command_file.js"]
+ "nashorn-simple" ["nashorn" "-opt" "-1" :nashorn-runner

This comment has been minimized.

Show comment Hide comment
@cemerick

cemerick Dec 17, 2014

Owner

@mikesperber There's two nashorn references here that are causing the Travis test failures.

@cemerick

cemerick Dec 17, 2014

Owner

@mikesperber There's two nashorn references here that are causing the Travis test failures.

This comment has been minimized.

Show comment Hide comment
@mikesperber

mikesperber Dec 18, 2014

Facepalm! Sorry about this ... Hopefully fixed.

Regards,
Mike

@mikesperber

mikesperber Dec 18, 2014

Facepalm! Sorry about this ... Hopefully fixed.

Regards,
Mike

@cemerick

This comment has been minimized.

Show comment Hide comment
@cemerick

cemerick Sep 15, 2015

Owner

Thank you for your efforts, but I've deprecated this project. Please see the notice at the top of the repo's README. This is a good thing, fundamentally. :-)

Owner

cemerick commented Sep 15, 2015

Thank you for your efforts, but I've deprecated this project. Please see the notice at the top of the repo's README. This is a good thing, fundamentally. :-)

@cemerick cemerick closed this Sep 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment