Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Default login-uri not valid in Location header #42

Closed
stuartsierra opened this Issue · 2 comments

2 participants

@stuartsierra

The default :login-uri is /login, which gets used in the "Location" header when generating redirects. Browsers may accept this, but it is not valid according to the HTTP spec, which requires an absolute URI.

Clients which expect an absolute URI in the "Location" header will fail in this case.

See this line in friend.clj

@cemerick
Owner

You're quite right. I had no idea that that required an absolute URI.

There's already a fn in friend to determine the complete URL corresponding to a ring request, so we have the raw materials we need. Would it seem suitable to resolve whatever is provided to :login-uri against the result of that function, and use that result as the value of Location?

@cemerick cemerick closed this issue from a commit
Commit has since been removed from the repository and is no longer available.
@cemerick cemerick closed this in 3e91490
@cemerick
Owner

Fixed based on what I mentioned last night. Will be in [com.cemerick/friend "0.1.3"] unless someone shrieks that I did something wrong. ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.