Support classifiers on install and deploy #52

Merged
merged 1 commit into from Feb 11, 2013

Projects

None yet

2 participants

@hugoduncan
Contributor

The current api doesn't allow the use of classifiers in pomegranate.aether/install or pomegranate.aether/deploy.

To allow this, I propose adding a :jar-files keyword argument, that takes a map from classifier keyword to jar file path or File. The nil classifier would be used for the unclassified jar.

The :jar-file argument would be maintained for simple uses cases and for backward compatibility.

@hugoduncan
Contributor

Looking further at the lein deploy code, I think it could be simplified by deploy taking a :file-map argument (instead of the :jar-files argument above), as a map from partial co-ordinates to file. The deploy function would then merge the partial co-ordinates into the main co-ordinates before passsing to the :artifacts argument deploy-artifacts.

@hugoduncan hugoduncan Generalise aether/install and deploy
Enables install and deploy to transfer multiple files, not just a single jar and
pom file.

Adds an :artifact-map option to pomegranate.aether/install and
pomegranate.aether/deploy, taking a map from partial coordinate to file path.

Removes the :artifacts keyword argument from deploy-artifacts and install-artifacts.
52673fa
@cemerick cemerick merged commit b52c22e into cemerick:master Feb 11, 2013

1 check passed

default The Travis build passed
Details
@cemerick
Owner

Thank you for elegantly killing the bad :artifacts/:files argument pairs. :-) Included in "0.1.4-SNAPSHOT".

@cemerick
Owner

Will be included in the next release, "0.2.0".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment