Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not emit BOM for Hime outputs #55

Closed
woutersl opened this issue Jul 24, 2018 · 2 comments

Comments

@woutersl
Copy link
Member

commented Jul 24, 2018

Original report by Laurent Wouters (Bitbucket: 557058:675792b6-d731-4823-9f7d-c6dfcb2df2b5, ).


A BOM can be emitted at the beginning of the text artifacts produced by Hime. This may be a problem for artifacts consumed by tools such as graphviz dot.
The BOM is emitted in cases as explained in: System.IO.StreamWriter.

For example when a constructor like this is used:

new StreamWriter(file, false, Encoding.UTF8)

This should be replaced by the use of UTF8Encoding instance without the BOM.

@woutersl

This comment has been minimized.

Copy link
Member Author

commented Jul 24, 2018

Original comment by Laurent Wouters (Bitbucket: 557058:675792b6-d731-4823-9f7d-c6dfcb2df2b5, ).


Verified

@woutersl

This comment has been minimized.

Copy link
Member Author

commented Jul 24, 2018

Original comment by Laurent Wouters (Bitbucket: 557058:675792b6-d731-4823-9f7d-c6dfcb2df2b5, ).


[fix] Fixed issue #55 Do not emit BOM for Hime outputs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.