Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Commit

Permalink
Fix handling errors in when failing to upload metrics proto (#171)
Browse files Browse the repository at this point in the history
  • Loading branch information
serathius authored and rghetia committed Jul 15, 2019
1 parent e19adcf commit 1aade25
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion metrics_proto.go
Expand Up @@ -207,7 +207,14 @@ func (se *statsExporter) convertSummaryMetrics(summary *metricspb.Metric) []*met
return metrics
}

func (se *statsExporter) handleMetricsProtoUpload(payloads []*metricProtoPayload) error {
func (se *statsExporter) handleMetricsProtoUpload(payloads []*metricProtoPayload) {
err := se.uploadMetricsProto(payloads)
if err != nil {
se.o.handleError(err)
}
}

func (se *statsExporter) uploadMetricsProto(payloads []*metricProtoPayload) error {
ctx, cancel := se.o.newContextWithTimeout()
defer cancel()

Expand Down

0 comments on commit 1aade25

Please sign in to comment.