Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run command mod tiny #1052

Merged
merged 6 commits into from Mar 15, 2019

Conversation

Projects
None yet
5 participants
@bogdandrutu
Copy link
Member

bogdandrutu commented Mar 11, 2019

No description provided.

@bogdandrutu bogdandrutu requested review from rakyll , rghetia and songy23 Mar 11, 2019

@songy23
Copy link
Member

songy23 left a comment

LGTM, though it looks like the modified go.sum doesn't work on Windows.

@bogdandrutu bogdandrutu force-pushed the bogdandrutu:gomod branch from a428a33 to 82b2a94 Mar 13, 2019

@bogdandrutu bogdandrutu requested a review from census-instrumentation/global-owners as a code owner Mar 13, 2019

@bogdandrutu bogdandrutu force-pushed the bogdandrutu:gomod branch 3 times, most recently from b910f70 to 8f6ade0 Mar 14, 2019

@bogdandrutu bogdandrutu referenced this pull request Mar 14, 2019

Closed

go.mod: update deps #1064

@jadekler

This comment has been minimized.

Copy link
Contributor

jadekler commented Mar 14, 2019

go: verifying git.apache.org/thrift.git@v0.12.0: checksum mismatch
	downloaded: h1:692K1/SsOcQvkvMRMdt60FCq2AvKpuQNM6sIeH3mN4s=
	go.sum:     h1:CMxsZlAmxKs+VAZMlDDL0wXciMblJcutQbEe3A9CYUM=

Maybe try rm go.sum && go mod tidy? Alternatively, try re-running the windows build. There's nothing windows specific about that failure - might just be a hiccup.

@dmitshur

This comment has been minimized.

Copy link

dmitshur commented Mar 15, 2019

It might've been a network error during download. It would be interesting to see what happens when you restart it.

bogdandrutu added some commits Mar 11, 2019

@bogdandrutu bogdandrutu force-pushed the bogdandrutu:gomod branch from 8f6ade0 to 8ba36b7 Mar 15, 2019

@bogdandrutu

This comment has been minimized.

Copy link
Member Author

bogdandrutu commented Mar 15, 2019

@dmitshur my current best guess it is because we vendor thrift and we imported it via the vendor path, changed everything to use github.com/apache/thrift

@dmitshur

This comment has been minimized.

Copy link

dmitshur commented Mar 15, 2019

It seems that the checksum mismatch keeps happening on Windows, it's not a network error. I see you're currently using Go 1.11 in appveyor.yml#L9. I wonder if anything would change if you were to update it to Go 1.12. It might be a bug in 1.11, so the question is whether it's been resolved in 1.12.

@bogdandrutu bogdandrutu force-pushed the bogdandrutu:gomod branch from c83e5e9 to 7009be9 Mar 15, 2019

@bogdandrutu

This comment has been minimized.

Copy link
Member Author

bogdandrutu commented Mar 15, 2019

@dmitshur I made progress by forcing to upgrade go but found different issue on 1.12. I will force 1.11.5.

@bogdandrutu bogdandrutu force-pushed the bogdandrutu:gomod branch from 7009be9 to d6d6be5 Mar 15, 2019

@bogdandrutu bogdandrutu merged commit 3b8e272 into census-instrumentation:master Mar 15, 2019

3 checks passed

cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bogdandrutu bogdandrutu deleted the bogdandrutu:gomod branch Mar 15, 2019

@bogdandrutu

This comment has been minimized.

Copy link
Member Author

bogdandrutu commented Mar 15, 2019

I think I won this battle :)

@bogdandrutu

This comment has been minimized.

Copy link
Member Author

bogdandrutu commented Mar 15, 2019

@jadekler I think it was because something changed in 1.11.2 when they fix a bug in go.sum, I remember seeing this bug at one point.

@dmitshur

This comment has been minimized.

Copy link

dmitshur commented Mar 15, 2019

@bogdandrutu Thank you for working on this!

Are you planning on tagging a new release version? That'll enable some other projects that depend on go.opencensus.io@v0.19.1 to update to a newer version.

@bogdandrutu

This comment has been minimized.

Copy link
Member Author

bogdandrutu commented Mar 15, 2019

we were planning to do in the next few days, if you cannot wait let me know. @rghetia what do you think?

@dmitshur

This comment has been minimized.

Copy link

dmitshur commented Mar 15, 2019

See #1064 (comment). I think it might make sense to try to resolve that issue before making a new tag.

@rghetia

This comment has been minimized.

Copy link
Contributor

rghetia commented Mar 15, 2019

we were planning to do in the next few days, if you cannot wait let me know. @rghetia what do you think?

I plan to release early next week with metric support.

@jadekler

This comment has been minimized.

Copy link
Contributor

jadekler commented Mar 20, 2019

Friendly ping - is there still a plan to release this week?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.