Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency from ourself, this happens because bundler in google.golang.org/api. #1068

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@bogdandrutu
Copy link
Member

bogdandrutu commented Mar 15, 2019

I have no idea if this is the right thing to do, but we kind of have a module cycle dependency but not a package cycle dependency. If anyone knows if I am doing the right thing please confirm :)

@bogdandrutu bogdandrutu requested review from rakyll , rghetia and census-instrumentation/global-owners as code owners Mar 15, 2019

@bogdandrutu

This comment has been minimized.

Copy link
Member Author

bogdandrutu commented Mar 15, 2019

@dmitshur any idea about what if I am doing here is correct?

  • go.opencensus.io dependend on google.golang.org/api just for the "support" package.
  • google.golang.org/api depends in other packages on go.opencensus.io
  • I added the replace with the idea that we have always a newer version.

@bogdandrutu bogdandrutu force-pushed the bogdandrutu:itself branch from 10dfd1d to b0effe6 Mar 15, 2019

@dmitshur

This comment has been minimized.

Copy link

dmitshur commented Mar 15, 2019

I'm not sure that this will actually work, for the following reason.

Replace directives of a go.mod file only apply when that module is the main module. When this module is required elsewhere, its replace directive has no effect.

Since the change here still has a requirement on google.golang.org/api@v0.2.0, which in turn requires go.opencensus.io@v0.19.1, and you're back to having a problem.

See my comment at googleapis/google-api-go-client#342 (comment) for a possible way to get out of this situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.