Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Remove dependency from ourself, this happens because bundler in google.golang.org/api. #1068

Closed

Conversation

bogdandrutu
Copy link
Contributor

I have no idea if this is the right thing to do, but we kind of have a module cycle dependency but not a package cycle dependency. If anyone knows if I am doing the right thing please confirm :)

@bogdandrutu bogdandrutu requested review from rakyll, rghetia and a team as code owners March 15, 2019 02:17
@bogdandrutu
Copy link
Contributor Author

@dmitshur any idea about what if I am doing here is correct?

  • go.opencensus.io dependend on google.golang.org/api just for the "support" package.
  • google.golang.org/api depends in other packages on go.opencensus.io
  • I added the replace with the idea that we have always a newer version.

@dmitshur
Copy link

I'm not sure that this will actually work, for the following reason.

Replace directives of a go.mod file only apply when that module is the main module. When this module is required elsewhere, its replace directive has no effect.

Since the change here still has a requirement on google.golang.org/api@v0.2.0, which in turn requires go.opencensus.io@v0.19.1, and you're back to having a problem.

See my comment at googleapis/google-api-go-client#342 (comment) for a possible way to get out of this situation.

@songy23
Copy link
Contributor

songy23 commented Apr 22, 2019

@songy23 songy23 closed this Apr 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants