fix(responsetemplate/mgr): improve description of 423 Empty API response

Author: KaiSchwarz-cnic

responsetemplate/responsetemplate.go

@@ -22,7 +22,7 @@ type ResponseTemplate struct {
 // NewResponseTemplate represents the constructor for struct ResponseTemplate.
 func NewResponseTemplate(raw string) *ResponseTemplate {
 	if len(raw) == 0 {
-		raw = "[RESPONSE]\r\nCODE=423\r\nDESCRIPTION=Empty API response\r\nEOF\r\n"
+		raw = "[RESPONSE]\r\nCODE=423\r\nDESCRIPTION=Empty API response. Probably unreachable API end point\r\nEOF\r\n"
 	}
 	rt := &ResponseTemplate{
 		Raw:  raw,

responsetemplate/responsetemplate_test.go

@@ -10,7 +10,7 @@ func TestConstructor(t *testing.T) {
 	if tpl.GetCode() != 423 {
 		t.Error("TestConstructor: Expected response code not matching.")
 	}
-	if strings.Compare(tpl.GetDescription(), "Empty API response") != 0 {
+	if strings.Compare(tpl.GetDescription(), "Empty API response. Probably unreachable API end point") != 0 {
 		t.Error("TestConstructor: Expected response description not matching.")
 	}
 }
@@ -20,7 +20,7 @@ func TestGetHash(t *testing.T) {
 	if v, ok := h["CODE"]; !ok || strings.Compare(v.(string), "423") != 0 {
 		t.Error("TestGetHash: Expected response code not matching.")
 	}
-	if v, ok := h["DESCRIPTION"]; !ok || strings.Compare(v.(string), "Empty API response") != 0 {
+	if v, ok := h["DESCRIPTION"]; !ok || strings.Compare(v.(string), "Empty API response. Probably unreachable API end point") != 0 {
 		t.Error("TestGetHash: Expected response description not matching.")
 	}
 }
@@ -33,7 +33,7 @@ func TestGetQueuetime1(t *testing.T) {
 }
 
 func TestGetQueuetime2(t *testing.T) {
-	tpl := NewResponseTemplate("[RESPONSE]\r\ncode=423\r\ndescription=Empty API response\r\nqueuetime=0\r\nEOF\r\n")
+	tpl := NewResponseTemplate("[RESPONSE]\r\ncode=423\r\ndescription=Empty API response. Probably unreachable API end point\r\nqueuetime=0\r\nEOF\r\n")
 	if tpl.GetQueuetime() != 0 {
 		t.Error("TestGetQueuetime2: Expected queuetime not matching")
 	}
@@ -47,7 +47,7 @@ func TestGetRuntime1(t *testing.T) {
 }
 
 func TestGetRuntime2(t *testing.T) {
-	tpl := NewResponseTemplate("[RESPONSE]\r\ncode=423\r\ndescription=Empty API response\r\nruntime=0.12\r\nEOF\r\n")
+	tpl := NewResponseTemplate("[RESPONSE]\r\ncode=423\r\ndescription=Empty API response. Probably unreachable API end point\r\nruntime=0.12\r\nEOF\r\n")
 	if tpl.GetRuntime() != 0.12 {
 		t.Error("TestGetRuntime2: Expected runtime not matching")
 	}
@@ -61,7 +61,7 @@ func TestIsPending1(t *testing.T) {
 }
 
 func TestIsPending2(t *testing.T) {
-	tpl := NewResponseTemplate("[RESPONSE]\r\ncode=423\r\ndescription=Empty API response\r\npending=1\r\nEOF\r\n")
+	tpl := NewResponseTemplate("[RESPONSE]\r\ncode=423\r\ndescription=Empty API response. Probably unreachable API end point\r\npending=1\r\nEOF\r\n")
 	if !tpl.IsPending() {
 		t.Error("TestIsPending2: Expected pending value not matching")
 	}

responsetemplatemanager/responsetemplatemanager.go

@@ -30,7 +30,7 @@ func GetInstance() *ResponseTemplateManager {
 			templates: map[string]string{
 				"404":          generateTemplate("421", "Page not found"),
 				"500":          generateTemplate("500", "Internal server error"),
-				"empty":        generateTemplate("423", "Empty API response"),
+				"empty":        generateTemplate("423", "Empty API response. Probably unreachable API end point"),
 				"error":        generateTemplate("421", "Command failed due to server error. Client should try again"),
 				"expired":      generateTemplate("530", "SESSION NOT FOUND"),
 				"httperror":    generateTemplate("421", "Command failed due to HTTP communication error"),