fix(gorgone) correctly handle gorgone pullwss module shutdown #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are limited to specific labels. Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
12 tasks
…g pullwss module. Refs:MON-34540
Zmq object need to be undef at the end of the module life or a C stack trace will appear in the logs. The sigterm handler was not called by perl, Mojo::IOLoop::Signal allow to correctly call the signal handler when quiting. Refs:MON-34540
Refs:MON-34540
Evan-Adam
force-pushed
the
MON-34540-error-on-logs-blaming-signaler.cpp-add-tests-migrate
branch
2 times, most recently
from
6bbe6e4
to
340826d
Compare
sdepassio
approved these changes
Jul 17, 2024
Evan-Adam
deleted the
MON-34540-error-on-logs-blaming-signaler.cpp-add-tests-migrate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrated from centreon/centreon#4178
This PR remove some C++ stack trace present when pullwss module unload by closing the zmq socket before the global destruction of the module.
It also use a new library Mojo::IOLoop::Signal to correctly handle sigterm signal, which was not always handled.
Fixes # (issue)
Type of change
Target serie
How this pull request can be tested ?
See the robot tests, connecting a poller to a central and disconecting them should not add any C++ level error in the poller logs. you should test both when the poller go down first (with a sigterm) and when the central go down first.Checklist
Community contributors & Centreon team