Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gorgone) correctly handle gorgone pullwss module shutdown #4178

Closed
wants to merge 4 commits into from
Closed

fix(gorgone) correctly handle gorgone pullwss module shutdown #4178

wants to merge 4 commits into from

Conversation

Evan-Adam
Copy link
Contributor

Description

This PR remove some C++ stack trace present when pullwss module unload by closing the zmq socket before the global destruction of the module.
It also use a new library Mojo::IOLoop::Signal to correctly handle sigterm signal, which was not always handled.

Fixes # (issue)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

Target serie

  • 22.10.x
  • 23.04.x
  • 23.10.x
  • 24.04.x
  • master

How this pull request can be tested ?

See the robot tests, connecting a poller to a central and disconecting them should not add any C++ level error in the poller logs. you should test both when the poller go down first (with a sigterm) and when the central go down first.

Checklist

Community contributors & Centreon team

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (master, maintenance).

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 24, 2024 •
edited
Loading

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Evan-Adam Evan-Adam force-pushed the MON-34540-error-on-logs-blaming-signaler.cpp-add-tests branch from 91b52c4 to e381b07 Compare May 24, 2024 11:55
@Evan-Adam Evan-Adam changed the base branch from MON-34873-gorgone-http-response-code-is-always-200 to MON-38230-test-wss-pull-standard-configuration-on-alma-8 May 24, 2024 11:55
@Evan-Adam Evan-Adam force-pushed the MON-34540-error-on-logs-blaming-signaler.cpp-add-tests branch from e381b07 to c47c2c0 Compare May 24, 2024 14:56
@Evan-Adam Evan-Adam force-pushed the MON-38230-test-wss-pull-standard-configuration-on-alma-8 branch 4 times, most recently from b060d0d to 21706ce Compare June 3, 2024 07:18
@Evan-Adam Evan-Adam force-pushed the MON-38230-test-wss-pull-standard-configuration-on-alma-8 branch 6 times, most recently from 2cb5053 to 66fc968 Compare June 13, 2024 08:29
Base automatically changed from MON-38230-test-wss-pull-standard-configuration-on-alma-8 to develop June 13, 2024 14:32
@Evan-Adam Evan-Adam force-pushed the MON-34540-error-on-logs-blaming-signaler.cpp-add-tests branch 2 times, most recently from 18878b8 to 2e96127 Compare June 24, 2024 11:34
@Evan-Adam
fix(gorgone) remove mojo::IoLoop->stop_gracefully() call when exiting…
e986ec6 
… pullwss module.

REF:MON-34540
@Evan-Adam
fix(gorgone) remove C libzmq error in log on shutdown
c5de781 
Zmq object need to be undef at the end of the module life or a C stack trace will appear in the logs.
The sigterm handler was not called by perl, Mojo::IOLoop::Signal allow to correctly call the signal handler when quiting.

REF:MON-34540
@Evan-Adam
ci(gorgone-docker): Wait longer for poller to be ready
16adea4 
Refs:MON-34540
@Evan-Adam
ci(gorgone-docker): add package as artifact
9650037 
Refs:MON-34540
@Evan-Adam Evan-Adam force-pushed the MON-34540-error-on-logs-blaming-signaler.cpp-add-tests branch from ab9e2b0 to 9650037 Compare June 28, 2024 15:29
@Evan-Adam Evan-Adam mentioned this pull request Jul 9, 2024
Merged
12 tasks
@kduret kduret mentioned this pull request Jul 11, 2024
Merged
12 tasks
@kduret
Copy link
Contributor

kduret commented Jul 11, 2024

Migrated to centreon/centreon-collect#1530

@kduret kduret closed this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Evan-Adam @kduret